Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove specific programmes field from the serializer #5483

Merged

Conversation

Richard-Pentecost
Copy link
Contributor

Description of change

Remove the serializer field for the specific programmes

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

@Richard-Pentecost Richard-Pentecost requested a review from a team as a code owner June 13, 2024 09:21
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.39%. Comparing base (1ffd2f8) to head (8168a52).
Report is 12 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5483   +/-   ##
=======================================
  Coverage   96.38%   96.39%           
=======================================
  Files         953      953           
  Lines       22516    22515    -1     
  Branches     2022     2022           
=======================================
+ Hits        21703    21704    +1     
+ Misses        660      659    -1     
+ Partials      153      152    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Richard-Pentecost Richard-Pentecost merged commit 69682ea into main Jun 13, 2024
2 checks passed
@Richard-Pentecost Richard-Pentecost deleted the bugfix/removeSerializerFieldForSpecificProgrammes branch June 13, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants