Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/cls2 849 investment projects record multiple programmes part 3 #5496

Conversation

Richard-Pentecost
Copy link
Contributor

@Richard-Pentecost Richard-Pentecost commented Jun 19, 2024

Description of change

Update admin and serializers to allow user to update specific_programme from specific_programmes field and to make both fields behave the same whilst migrating from 'one to many' to a 'many to many' relationship

Checklist

  • Has this branch been rebased on top of the current main branch?

    Explanation

    The branch should not be stale or have conflicts at the time reviews are requested.

  • Is the CircleCI build passing?

General points

Other things to check

  • Make sure fixtures/test_data.yaml is maintained when updating models
  • Consider the admin site when making changes to models
  • Use select-/prefetch-related field lists in views and search apps, and update them when fields are added
  • Make sure the README is updated e.g. when adding new environment variables

See docs/CONTRIBUTING.md for more guidelines.

Richard Pentecost added 3 commits June 19, 2024 15:20
@Richard-Pentecost Richard-Pentecost marked this pull request as ready for review June 19, 2024 14:45
@Richard-Pentecost Richard-Pentecost requested a review from a team as a code owner June 19, 2024 14:45
@Richard-Pentecost Richard-Pentecost force-pushed the feature/CLS2-849-investment-projects-record-multiple-programmes-part-3 branch from 595e3ee to 5bb2330 Compare June 19, 2024 14:52
@Richard-Pentecost Richard-Pentecost force-pushed the feature/CLS2-849-investment-projects-record-multiple-programmes-part-3 branch from 5bb2330 to 6b964ae Compare June 19, 2024 15:13
@Richard-Pentecost Richard-Pentecost merged commit 1dba7f5 into main Jun 21, 2024
2 checks passed
@Richard-Pentecost Richard-Pentecost deleted the feature/CLS2-849-investment-projects-record-multiple-programmes-part-3 branch June 21, 2024 09:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants