Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/modify user theia permissions #221

Merged
merged 15 commits into from
Jan 22, 2025
Merged

Feature/modify user theia permissions #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
15 commits
Select commit Hold shift + click to select a range
7267ac6
simplify autoscaling process
aidanrussell Jan 20, 2025
543c8b4
alter user permissions for boto3 usage in theia@
aidanrussell Jan 20, 2025
bf66e5c
latest
aidanrussell Jan 21, 2025
0472da5
all terraform names with underscores not dashes
aidanrussell Jan 21, 2025
d5c1d0c
correct sagemaker_llms
aidanrussell Jan 21, 2025
0c1189a
remove theia permissions adjustment
aidanrussell Jan 21, 2025
d430c9b
Merge branch 'bugfix/simplify_autoscaling' of github.com:uktrade/data…
aidanrussell Jan 21, 2025
714c603
incorporate latest simplify_autoscaling branch
aidanrussell Jan 21, 2025
10f7912
correct user permissions
aidanrussell Jan 21, 2025
b90ecb4
shorten timeframes
aidanrussell Jan 21, 2025
f835808
Merge branch 'bugfix/simplify_autoscaling' of github.com:uktrade/data…
aidanrussell Jan 21, 2025
42460ae
latest
aidanrussell Jan 21, 2025
470c05d
correct slack channels
aidanrussell Jan 21, 2025
2845b05
resolve merge conflicts
aidanrussell Jan 22, 2025
a2a4cfb
correct errors in conflict resolution@
aidanrussell Jan 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
24 changes: 15 additions & 9 deletions infra/ecs_notebooks_notebook.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -124,11 +124,13 @@ data "aws_iam_policy_document" "notebook_task_execution" {

statement {
actions = [
"sagemaker:InvokeEndpoint",
"sagemaker:DescribeEndpoint",
"sagemaker:DescribeEndpointConfig",
"sagemaker:DescribeModel",
"sagemaker:InvokeEndpointAsync",
"sagemaker:ListEndpoints",
"sagemaker:DescribeEndpoint",
"sagemaker:DescibeTransformJob"
"sagemaker:ListEndpointConfigs",
"sagemaker:ListModels",
]

resources = [
Expand Down Expand Up @@ -274,11 +276,13 @@ data "aws_iam_policy_document" "notebook_s3_access_template" {
# Temporary: Allow SageMaker access for all DW tools users
statement {
actions = [
"sagemaker:InvokeEndpoint",
"sagemaker:DescribeEndpoint",
"sagemaker:DescribeEndpointConfig",
"sagemaker:DescribeModel",
"sagemaker:InvokeEndpointAsync",
"sagemaker:ListEndpoints",
"sagemaker:DescribeEndpoint",
"sagemaker:DescibeTransformJob"
"sagemaker:ListEndpointConfigs",
"sagemaker:ListModels",
]

resources = [
Expand Down Expand Up @@ -478,11 +482,13 @@ data "aws_iam_policy_document" "jupyterhub_notebook_task_boundary" {
# Temporary: Allow all tools users to access SageMaker endpoints
statement {
actions = [
"sagemaker:InvokeEndpoint",
"sagemaker:DescribeEndpoint",
"sagemaker:DescribeEndpointConfig",
"sagemaker:DescribeModel",
"sagemaker:InvokeEndpointAsync",
"sagemaker:ListEndpoints",
"sagemaker:DescribeEndpoint",
"sagemaker:DescibeTransformJob"
"sagemaker:ListEndpointConfigs",
"sagemaker:ListModels",
]

resources = [
Expand Down
8 changes: 5 additions & 3 deletions infra/vpc.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -887,11 +887,13 @@ data "aws_iam_policy_document" "sagemaker_notebooks_endpoint_policy" {
identifiers = ["*"]
}
actions = [
"sagemaker:InvokeEndpoint",
"sagemaker:DescribeEndpoint",
"sagemaker:DescribeEndpointConfig",
"sagemaker:DescribeModel",
"sagemaker:InvokeEndpointAsync",
"sagemaker:ListEndpoints",
"sagemaker:DescribeEndpoint",
"sagemaker:DescibeTransformJob"
"sagemaker:ListEndpointConfigs",
"sagemaker:ListModels",
]
resources = [
"*"
Expand Down