WIP: feat/version numbers formatting #231
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
isobel-daley-6point6
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This might require some debate - I created a new workflow for giving a version number and in the process initiated additional workflows for formatting both terraform and python (python formatting having been ignored up to now) according to a format I typically have used in the past i.e. Makefiles that I find useful for avoiding having to memorise too many CLI commands.
I kept this within the infra/modules/ folder as a way to introduce gently to the main data-workspace codebase so as not to introduce immediately to the root of the folder which other teams edit and may not agree on the standards.
Note that the part for auto-bumping format number may not be possible if main data-workspace team do not agree - that's OK because we can still implement the rest - we'll just need to manually implement version number bumps before we merge changes.