Skip to content

Commit

Permalink
Use TemplateView for bulk approval
Browse files Browse the repository at this point in the history
As there is really no form to submit, templateview is better
  • Loading branch information
saruniitr committed Jan 14, 2025
1 parent 72bc8fc commit ac5d02c
Showing 1 changed file with 5 additions and 11 deletions.
16 changes: 5 additions & 11 deletions caseworker/advice/views/bulk_approval.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,12 +2,11 @@

from http import HTTPStatus

from django import forms
from django.contrib import messages
from django.contrib.messages.views import SuccessMessageMixin
from django.http import Http404
from django.http import Http404, HttpResponseRedirect
from django.urls import reverse
from django.views.generic import FormView
from django.views.generic import TemplateView


from caseworker.advice.services import post_bulk_approval_recommendation
Expand All @@ -17,17 +16,12 @@
from core.decorators import expect_status


class BulkApprovalForm(forms.Form):
pass


class BulkApprovalView(LoginRequiredMixin, SuccessMessageMixin, FormView):
class BulkApprovalView(LoginRequiredMixin, SuccessMessageMixin, TemplateView):
"""
Submit approval recommendation for the selected cases
"""

template_name = "core/form.html"
form_class = BulkApprovalForm

def dispatch(self, *args, **kwargs):

Expand Down Expand Up @@ -55,7 +49,7 @@ def get_success_url(self):
def submit_bulk_approval_recommendation(self, queue_id, payload):
return post_bulk_approval_recommendation(self.request, queue_id, payload)

def form_valid(self, form):
def post(self, request, *args, **kwargs):
queue_id = self.kwargs["pk"]
cases = self.request.POST.getlist("cases", [])
payload = {
Expand All @@ -78,4 +72,4 @@ def form_valid(self, form):
success_message = "Successfully approved 1 case"
messages.success(self.request, success_message)

return super().form_valid(form)
return HttpResponseRedirect(self.get_success_url())

0 comments on commit ac5d02c

Please sign in to comment.