Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add a policy to allow services to access global SSM parameters #531

Merged
merged 1 commit into from
Aug 19, 2024

Conversation

lgarvey
Copy link
Member

@lgarvey lgarvey commented Aug 15, 2024

Addresses .

This PR adds an additional policy to the service task role so that services can retrieve secrets tagged with Copilot-application = '__all__'.

This enables services to read SSM parameters that are global/account wide such as the VPC EGRESS_IP SSM parameter, and the prometheus /observability/prometheus/adot_config parameters.

There are two associated PRs to add these tags to global SSM params:
uktrade/terraform-platform-modules#201
uktrade/terraform-module-aws_account#74

A platform-documentation PR is required - it'll be raised before merging this PR.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@lgarvey lgarvey changed the title fix: add a policy to allow sedrvices to access global SSM parameters fix: add a policy to allow services to access global SSM parameters Aug 16, 2024
@lgarvey lgarvey merged commit 6fb9795 into main Aug 19, 2024
7 checks passed
@lgarvey lgarvey deleted the DBTP-1154-allow-access-to-global-ssm-params branch August 19, 2024 09:38
@lgarvey lgarvey restored the DBTP-1154-allow-access-to-global-ssm-params branch August 19, 2024 09:38
@lgarvey lgarvey deleted the DBTP-1154-allow-access-to-global-ssm-params branch August 19, 2024 09:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants