Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: DBTP-1643 - Adding exceptions in ConfigValidator #745

Merged
merged 10 commits into from
Jan 31, 2025

Conversation

chiaramapellimt
Copy link
Contributor

@chiaramapellimt chiaramapellimt commented Jan 29, 2025

Addresses DBTP-1643


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • If the work includes user interface changes, before and after screenshots included in description
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

  • Run the end to end tests for this branch and confirm that they are passing

@codecov-commenter
Copy link

codecov-commenter commented Jan 29, 2025

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
684 1 683 3
View the top 1 failed tests by shortest run time
tests/platform_helper/providers/test_config.py::test_validation_fails_if_invalid_pipeline_version_override_keys_present[terraform-platform-modules]
Stack Traces | 0.136s run time
.../platform_helper/providers/test_config.py:299: in test_validation_fails_if_invalid_pipeline_version_override_keys_present
    config_provider.load_and_validate_platform_config()
dbt_platform_helper/providers/config.py:47: in load_and_validate_platform_config
    self.config = self.file_provider.load(path)
dbt_platform_helper/providers/yaml_file.py:47: in load
    YamlFileProvider.lint_yaml_for_duplicate_keys(path)
dbt_platform_helper/providers/yaml_file.py:59: in lint_yaml_for_duplicate_keys
    with open(path, "r") as yaml_file:
E   FileNotFoundError: [Errno 2] No such file or directory: 'platform-config.yml'

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@chiaramapellimt chiaramapellimt marked this pull request as ready for review January 31, 2025 09:45
@chiaramapellimt chiaramapellimt requested a review from a team as a code owner January 31, 2025 09:45
@chiaramapellimt chiaramapellimt merged commit b60ad7b into main Jan 31, 2025
9 checks passed
@chiaramapellimt chiaramapellimt deleted the DBTP-1643 branch January 31, 2025 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants