Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - Add env permission in resources not statements #315

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Jan 20, 2025

We're currently using dynamic statements for environment specific permissions which is duplicating the entire statement for each environment.

Instead we can loop the environments in the resources section of a statement, only deploying one statement.

Addresses DBTP-

Please add any relevant context for you pull request here, or delete this if none needed.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (cbad429) to head (9275f4b).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #315   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files           5        5           
  Lines         814      814           
=======================================
  Hits          658      658           
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnStainsby JohnStainsby changed the title Add environment specific resources to statements rather than separate… WIP - Add env permission in resources not statements Jan 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants