Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Missing environment pipeline permissions #318

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

JohnStainsby
Copy link
Contributor

@JohnStainsby JohnStainsby commented Jan 23, 2025

Add permission to delete lambda functions and detach role policies.


Checklist:

Title:

  • Scope included as per conventional commits
  • Ticket reference included (unless it's a quick out of ticket thing)

Description:

  • Link to ticket included (unless it's a quick out of ticket thing)
  • Includes tests (or an explanation for why it doesn't)
  • Includes any applicable changes to the documentation in this code base
  • Includes link(s) to any applicable changes to the documentation in the DBT Platform Documentation (can be to a pull request)

Tasks:

@JohnStainsby JohnStainsby requested a review from a team as a code owner January 23, 2025 09:52
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.83%. Comparing base (8baeb9e) to head (a273aab).

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #318   +/-   ##
=======================================
  Coverage   80.83%   80.83%           
=======================================
  Files           5        5           
  Lines         814      814           
=======================================
  Hits          658      658           
  Misses        156      156           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@JohnStainsby JohnStainsby merged commit 155f371 into main Jan 23, 2025
56 checks passed
@JohnStainsby JohnStainsby deleted the missing-env-pipelines-permissions branch January 23, 2025 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants