-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support multiple source buckets for data migration #321
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #321 +/- ##
=======================================
Coverage 80.83% 80.83%
=======================================
Files 5 5
Lines 814 814
=======================================
Hits 658 658
Misses 156 156 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. Couple of small suggestions, but approving.
@@ -67,7 +67,12 @@ variable "config" { | |||
source_bucket_arn = string | |||
source_kms_key_arn = optional(string) | |||
worker_role_arn = string | |||
})) | |||
})), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Probably worth including a comment above import
mentioning that it is deprecated.
Co-authored-by: Will Gibson <[email protected]>
Move to a nested structure to support multiple source buckets for data migration
Addresses DBTP-1635
Docs PR: https://github.com/uktrade/platform-documentation/pull/457
Checklist:
Title:
Description:
Tasks: