Async benches #64
Closed
Async benches #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… running, must be called from the context of a Tokio 1.x runtime'-type errors... needs a bit more work to fully migrate to async, see: bheisler/criterion.rs@a74edd9
|
Runs well locally but it does deserve a bit more attention on the criterion_async side and its Futures: https://github.com/umccr/htsget-rs/runs/3752074281?check_suite_focus=true#step:6:223 will take a look at it... |
|
Will be deprecated by #46 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To avoid 'there is no reactor is running, must be called from the context of a Tokio 1.x runtime'-type errors... needs a bit more work to fully migrate to async, see bheisler/criterion.rs@a74edd9
@CastilloDel Please note that this PR is against your current
benchmarksbranch, notmain... don't worry I can tackle the blocking version later, this one seems to be working now ;)