Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gives oncoanalyser roles access to read/write to cohort projects #118

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

alexiswl
Copy link
Member

@alexiswl alexiswl commented Feb 2, 2025

No description provided.

@alexiswl alexiswl self-assigned this Feb 2, 2025
Copy link
Member

@scwatts scwatts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! There already is a wildcard for prefixes used in bucket action grants so may not need these here. See:

orcabusDataBucket.grantReadWrite(role, `${props.orcabusDataS3PrefixTemp}*`);
orcabusDataBucket.grantDelete(role, `${props.orcabusDataS3PrefixTemp}*`);
orcabusDataBucket.grantReadWrite(role, `${props.orcabusDataS3PrefixOutput}*`);
orcabusDataBucket.grantRead(role, `${props.orcabusDataS3ByobPrefix}*`)

Copy link
Member

@reisingerf reisingerf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy for now, but we should sort this out properly...

@alexiswl
Copy link
Member Author

alexiswl commented Feb 3, 2025

There already is a wildcard for prefixes used in bucket action grants so may not need these here. See:

Run failed immediately with permission errors without setting the asterisk after byob-icav2/*

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants