Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support to create Alias Records and Changing the State of a Pre-existing #16

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

danpfe
Copy link

@danpfe danpfe commented Mar 2, 2022

IP (for example if a previously created VM already took an address from
the DHCP pool).

IP (for example if a previously created VM already took an address from
the DHCP pool).
@danpfe
Copy link
Author

danpfe commented Mar 2, 2022

Hi guys, for some use-cases here at work we needed to be able to create alias records and change the state of a previously allocated IP address (such as the case where we created a VM that took its IP from a DHCP pool and then need to make it "DHCP_RESERVED"). Thought I'd contribute back the stuff I did and hope you find it useful.

@adarobin adarobin self-requested a review June 14, 2022 14:48
@adarobin adarobin self-assigned this Jun 14, 2022
@adarobin
Copy link
Member

@danpfe I appreciate the PR! I like the alias record stuff, but I'm not 100% a fan of bluecat_ip4_change_state being a separate resource. I'm wondering if that logic should just be in bluecat_ip4_address and get rid of the ForceNew attribute from the action field.

@danpfe
Copy link
Author

danpfe commented Jun 14, 2022

@adarobin I am absolutely willing to discuss the change_state resource, I know it's not "pretty" to have a resource that isn't really a resource; however: the reason I did it this way was because I didn't want to break the existing logic of "bluecat_ip4_address" for the use-case I described above (i.e. when it's not really "us" creating the IP in Terraform but it came into existance by being DHCP_ALLOCATED).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants