Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: chunk groups' order when building mpa #1763

Merged
merged 1 commit into from
Jan 20, 2025
Merged

Conversation

xusd320
Copy link
Contributor

@xusd320 xusd320 commented Jan 17, 2025

The entry modules' order should be stable, or else, the css order in common chunks will be unstable.

Copy link

codecov bot commented Jan 17, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 55.03%. Comparing base (9c55f1c) to head (c731eff).
Report is 6 commits behind head on master.

Files with missing lines Patch % Lines
crates/mako/src/module_graph.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1763      +/-   ##
==========================================
+ Coverage   54.80%   55.03%   +0.22%     
==========================================
  Files         180      180              
  Lines       18083    18146      +63     
==========================================
+ Hits         9911     9987      +76     
+ Misses       8172     8159      -13     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@xusd320 xusd320 force-pushed the fix/chunk-groups-mpa branch from 4d93ccb to c731eff Compare January 20, 2025 02:31
@xusd320 xusd320 merged commit 3524214 into master Jan 20, 2025
16 checks passed
@xusd320 xusd320 deleted the fix/chunk-groups-mpa branch January 20, 2025 02:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants