fix(SSR): 防止多chunk情况下（有懒加载时）的文件名冲突报错 #11823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: chencheng (云谦) <[email protected]>
以解决 react-dom/server renderToReadableStream 不存在的问题
… Workers的平台" This reverts commit 5b0946a.
Co-authored-by: 咲奈Sakina <[email protected]>
Co-authored-by: 咲奈Sakina <[email protected]>
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11823 +/- ##
=======================================
Coverage 29.02% 29.02%
=======================================
Files 488 488
Lines 14829 14829
Branches 3513 3513
=======================================
Hits 4304 4304
Misses 9765 9765
Partials 760 760
☔ View full report in Codecov by Sentry. |
PeachScript
reviewed
Nov 2, 2023
| @@ -46,9 +46,10 @@ export const build = async (api: IApi, opts: any) => { | |||
|
|
|||
| memo.output | |||
| .path(dirname(absOutputFile)) | |||
| .filename(useHash ? 'umi.[contenthash:8].server.js' : 'umi.server.js') | |||
| // 防止多chunk情况下（有懒加载时）的文件名冲突报错 | |||
| .filename(useHash ? '[name].[contenthash:8].server.js' : '[name].server.js') | |||
There was a problem hiding this comment.
ssr 下会默认把 dynamic import 转换，理论上不会出现多 chunk：
umi/packages/preset-umi/src/features/ssr/webpack/webpack.ts
Lines 24 to 28 in fb0a75f
可以提供复现看看是什么原因引起的
sorrycc
reviewed
Nov 2, 2023
|
下次提代码的时候不要带着之前的 commit 记录，一大串很丑，可以通过设定新的 remote 然后每次从上游 master 拉新的分支开发就好： git remote add up https://github.com/umijs/umi.git
# ↑ 在自己 fork 的仓库里这样添加一个上游，下次先同步所有远程仓库信息后，从 up/master checkout 新分支。 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.