Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(SSR): 支持通过导出metadataLoader()设置页面的TDK等meta信息 #11833

Merged
merged 59 commits into from
Nov 7, 2023
Merged

feature(SSR): 支持通过导出metadataLoader()设置页面的TDK等meta信息 #11833

merged 59 commits into from
Nov 7, 2023

Conversation

gwuhaolin
Copy link
Member

@gwuhaolin gwuhaolin commented Nov 6, 2023

实现 #11834

奇风 and others added 30 commits October 8, 2023 12:00
Copy link

vercel bot commented Nov 6, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Ignored Deployment
Name Status Preview Comments Updated (UTC)
umi ⬜️ Ignored (Inspect) Visit Preview Nov 7, 2023 3:45am

Copy link

codecov bot commented Nov 6, 2023

Codecov Report

Attention: 27 lines in your changes are missing coverage. Please review.

Comparison is base (84b5ca1) 28.95% compared to head (b46fac8) 28.92%.

❗ Current head b46fac8 differs from pull request most recent head c7df640. Consider uploading reports for the commit c7df640 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master   #11833      +/-   ##
==========================================
- Coverage   28.95%   28.92%   -0.03%     
==========================================
  Files         488      488              
  Lines       14863    14878      +15     
  Branches     3530     3537       +7     
==========================================
  Hits         4303     4303              
- Misses       9802     9817      +15     
  Partials      758      758              
Files Coverage Δ
...ackages/preset-umi/src/features/tmpFiles/routes.ts 57.48% <0.00%> (-0.46%) ⬇️
packages/server/src/types.ts 0.00% <0.00%> (ø)
packages/renderer-react/src/server.tsx 0.00% <0.00%> (ø)
packages/server/src/ssr.ts 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

packages/renderer-react/src/server.tsx Outdated Show resolved Hide resolved
packages/server/src/ssr.ts Show resolved Hide resolved
packages/server/src/ssr.ts Outdated Show resolved Hide resolved
packages/server/src/ssr.ts Outdated Show resolved Hide resolved
packages/renderer-react/src/server.tsx Outdated Show resolved Hide resolved
packages/renderer-react/src/server.tsx Outdated Show resolved Hide resolved
packages/server/src/ssr.ts Outdated Show resolved Hide resolved
@fz6m
Copy link
Contributor

fz6m commented Nov 7, 2023

  1. 合并下现有 master 最新代码吧,有一些变化了。

  2. 需要补充 MetaLoader 的类型,导出位置在 packages/preset-umi/src/features/ssr/ssr.ts ,类型编写位置在 packages/server/src/types.ts

  3. 需要添加 example 示例。

@fz6m
Copy link
Contributor

fz6m commented Nov 7, 2023

可以重新提一个 PR ,从本仓库的 master 最新代码迁出新的分支来添加新的代码和 commit ,而不应该保留历史上的大量 commit 记录干扰:

@fz6m
Copy link
Contributor

fz6m commented Nov 7, 2023

  1. 另希望尽早对 ssr 新增的几个用于 serverless 的函数开一个新的 PR 补充简单的测试(单测或 e2e)用例,简单的调用验证返回结果即可,防止因频繁的 ssr 部分代码改动导致此部分功能在下一个版本中挂掉。

  2. 同时希望楼主在提交 umi 仓库代码时,不要跳过自动的 lint stage 代码格式化,或在提交前手动按下 prettier 格式化按键格式化要改动的文件,因为一旦不格式化提交上来,对所有其他 PR 都会带来很大的副作用,再去 merge master 时就会导致大量不属于他们本身的格式化,为了保证提交的原子性,请务必格式化,可以排查下本地仓库的 git hooks 是否正常运作。

@gwuhaolin
Copy link
Member Author

可以重新提一个 PR ,从本仓库的 master 最新代码迁出新的分支来添加新的代码和 commit ,而不应该保留历史上的大量 commit 记录干扰:

下次吧,这次就先继续用这个,不重新提PR了

@fz6m fz6m merged commit e63fed3 into umijs:master Nov 7, 2023
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants