-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
revert: "fix(ssr): support ant design pro ssr (#11702)" #11854
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit a830383.
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Ignored Deployment
|
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## master #11854 +/- ##
=======================================
Coverage 28.91% 28.92%
=======================================
Files 488 488
Lines 14881 14877 -4
Branches 3537 3535 -2
=======================================
Hits 4303 4303
+ Misses 9820 9816 -4
Partials 758 758
☔ View full report in Codecov by Sentry. |
Size Change: -140 B (0%) Total Size: 9.89 MB
ℹ️ View Unchanged
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This reverts commit a830383.
先回退该 PR 的改动发版,回退原因:
route.path
的判定会影响index.html
的生成,因为首页的route.path
默认是''
undefined.html
的问题,但还没有复现该问题,需要找到真正原因,理论上route
对象都应该有path
,在这里判定也许不是本质解helmetContext.helmet
默认情况下是一定存在的,如果不存在说明HelmetProvider
的注入存在问题,这里做?.
只是避免报错但没有解决 ssr helmet 信息丢失的问题,在 pro 项目里可以复现该问题,但 dumi 同样用了 ssr + exportStatic 却工作正常,需要看下真正原因