docs: replace SC with css modules #12035
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12035 +/- ##
=======================================
Coverage 28.76% 28.76%
=======================================
Files 489 489
Lines 14964 14964
Branches 3555 3555
=======================================
Hits 4305 4305
Misses 9893 9893
Partials 766 766 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
先把 SC 去掉用 css modules 替换吧。
SC 是支持 ssr 但目前 umi ssr 不完善，缺少一种插件机制去干预 render 的过程从而 collect 一些第三库的东西，比如目前 helment 其实都是写死到代码里的，不能作为插件机制去干预，如果未来 umi 5 要做 ssr 应该要考虑这些。