-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: upgrade node to 18 #12380
docs: upgrade node to 18 #12380
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
概述这次修改主要更新了项目中所需的 Node.js 版本,从 14 或 16 升级到 18。这一改变体现在多个文档中,涉及环境设置指南和 Umi.js 开发的要求。 变更
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
Review Details
Configuration used: CodeRabbit UI
Review profile: CHILL
Files selected for processing (6)
- docs/docs/docs/guides/getting-started.en-US.md (2 hunks)
- docs/docs/docs/guides/getting-started.md (2 hunks)
- docs/docs/docs/guides/prepare.en-US.md (2 hunks)
- docs/docs/docs/guides/prepare.md (2 hunks)
- docs/docs/docs/introduce/contributing.en-US.md (1 hunks)
- docs/docs/docs/introduce/contributing.md (1 hunks)
Files skipped from review due to trivial changes (1)
- docs/docs/docs/guides/prepare.en-US.md
Additional comments not posted (9)
docs/docs/docs/guides/prepare.md (3)
12-12
: 确保 Node.js 版本信息更新准确无误。
31-32
: 更新 Node.js 版本的命令已正确修改为18,符合文档整体更新目的。
40-40
: 示例中显示的 Node.js 版本已更新至 v18.14.0,与文档中的要求一致。docs/docs/docs/introduce/contributing.md (1)
14-14
: 更新了开发 Umi 所需的 Node.js 版本要求至18+,确保文档与实际开发环境要求一致。docs/docs/docs/guides/getting-started.md (2)
9-9
: 更新了 Node.js 版本要求至18或以上,与项目的最新要求保持一致。
22-25
: Node.js 安装和使用的命令已正确更新至版本18,确保用户按照最新的指南操作。docs/docs/docs/guides/getting-started.en-US.md (2)
11-11
: 确保 Node.js 版本信息更新准确无误,与中文版本保持一致。
24-27
: Node.js 安装和使用的命令已正确更新至版本18,确保用户按照最新的指南操作。docs/docs/docs/introduce/contributing.en-US.md (1)
15-15
: 更新了开发 Umi 所需的 Node.js 版本要求至18+,确保文档与实际开发环境要求一致。
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #12380 +/- ##
==========================================
- Coverage 28.40% 28.39% -0.02%
==========================================
Files 492 494 +2
Lines 15171 15248 +77
Branches 3630 3653 +23
==========================================
+ Hits 4310 4330 +20
- Misses 10088 10142 +54
- Partials 773 776 +3 ☔ View full report in Codecov by Sentry. |
不改代码里的版本校验吗?这是针对 mako 需要的 node 18 么。 |
目前 node 16 已经不维护了~ 我们文档里面推荐用 16 的地方 改成 18 吧 --- BY 辟殊 |
文档 node 版本版本更新到 18
Summary by CodeRabbit