Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(plugins): icons enhanced feature can be used for layout menu #12515

Merged
merged 6 commits into from
Jul 12, 2024
Merged

feat(plugins): icons enhanced feature can be used for layout menu #12515

Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b89761b
feat(max/layout): 支持菜单图标使用图标集或者本地图标
Donovan-Ye Jul 1, 2024
70e7f20
refactor(max/layout): 根据icons功能是否开启动态插入菜单项使用icons功能的代码
Donovan-Ye Jul 4, 2024
0fa4819
refactor(layout/max): 使用api.isPluginEnable判断是否开启了icons功能
Donovan-Ye Jul 4, 2024
3436126
docs(layout-menu): 更新layout中菜单icon相关的文档
Donovan-Ye Jul 4, 2024
e1cdf7e
chore: Merge branch 'master' of github.com:umijs/umi
Donovan-Ye Jul 7, 2024
16495ed
docs(layout-menu): 修改菜单icon说明中的绝对路径为相对路径
Donovan-Ye Jul 7, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 12 additions & 2 deletions packages/plugins/src/layout.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -423,13 +423,19 @@ export default { ${icons.join(', ')} };
`,
});

// 是否启用了 icons 功能
const isIconsFeatureEnable = !!api.config.icons;
fz6m marked this conversation as resolved.
Show resolved Hide resolved
// runtime.tsx
api.writeTmpFile({
path: 'runtime.tsx',
content: `
import React from 'react';
import icons from './icons';
import { Icon, getIconComponent } from '@umijs/max';
${
isIconsFeatureEnable
? `import { Icon, getIconComponent } from '@umijs/max';`
: ''
}

function formatIcon(name: string) {
return name
Expand All @@ -443,10 +449,14 @@ export function patchRoutes({ routes }) {
Object.keys(routes).forEach(key => {
const { icon } = routes[key];
if (icon && typeof icon === 'string') {
const Component = getIconComponent(icon)
${
isIconsFeatureEnable
? `const Component = getIconComponent(icon)
if (Component) {
routes[key].icon = <Icon icon={icon} width={14} height={14} />;
fz6m marked this conversation as resolved.
Show resolved Hide resolved
return;
}`
: ''
}

const upperIcon = formatIcon(icon);
Expand Down