Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow adding existing users to rotations #47

Merged
merged 2 commits into from
Apr 17, 2017
Merged

Allow adding existing users to rotations #47

merged 2 commits into from
Apr 17, 2017

Conversation

dfaulken
Copy link
Contributor

Addresses #44.

@dfaulken dfaulken requested a review from Anbranin April 17, 2017 19:47
@dfaulken
Copy link
Contributor Author

screenshot from 2017-04-17 15-47-51

Anbranin
Anbranin reviewed Apr 17, 2017
View reviewed changes
app/controllers/users_controller.rb
@fallback = @roster.fallback_user
end

def transfer
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

'transfer' makes me think we're moving a user from one roster to another.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just add_roster?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

eh but that's using the word 'roster' more, so I'm not really hooked on changing this.

@dfaulken dfaulken merged commit 7d49a35 into master Apr 17, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Anbranin Anbranin Anbranin approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dfaulken @Anbranin