Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP - 4175 add request type flag #2

Open
wants to merge 316 commits into
base: main
Choose a base branch
from

Conversation

nathangthomas
Copy link

Resolves #1

Description

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Documentation update

How Has This Been Tested?

Screenshots

Move Manufacturer Donations Cards to Donations | Manufacturer
…ty-card-3798

Move dashboard activity card to a standalone report [rubyforgood#3798]
…t-drives-card-to-product-drives

rubyforgood#3734 Move product drives card to product drives
…tions-filter-3735

Add the date filter to the donation report [rubyforgood#3735]
awwaiid and others added 30 commits May 12, 2024 15:19
…ntainer-updates

Aeisenberg devcontainer updates
…in view to display only the first letter, pull request_type from service instead of defining with an instance var.
…man-essentials into 4175-add-request-type-flag
* Update README to indicate that codespace takes a bit to start

* Add updates to Gemfile.lock and schema.rb from clean env build
* Move routes outside of organization_name scope

* Remove 'organization_url_options' and 'default_url_options' helpers

* Remove organization param for paths used in controllers

* Update path for distribution calendars

Following change in route

* Remove organization_name from barcode_items JS utils

* Rename csv templates to avoid conflict with new route paths

* Remove links going outside of admin namespace from admin views

* Remove organization_name param from views

* Remove extra parentheses surrounding paths (nitpick)

* Update route paths in system tests

* Update OrganizationPage test support to not use organization short name

* Remove test support pages that are no longer required

Now that URLs don't require organization names are prefix

* Remove organization_name param from system tests

* Remove organization_name param from requests tests

* Remove organization_name param from controller tests

* Update route paths in mailer tests

* Fix test after merging main

* Add organization ID for admin views where links were removed

Refer to commit 983455f

* Remove skipped tests from organization requests tests

* Refactor profiles requests tests to remove 'default_params'

* Add await_select2 helper to audit system test

* Fix params in profiles requests test

* Lint code

* Fix audit and organization system tests

* Fix inventory aggregate event test

* Remove 'default_params' for reports requests tests

---------

Co-authored-by: Daniel Orner <[email protected]>
…ubyforgood#4355)

Bumps [omniauth-rails_csrf_protection](https://github.com/cookpad/omniauth-rails_csrf_protection) from 1.0.1 to 1.0.2.
- [Release notes](https://github.com/cookpad/omniauth-rails_csrf_protection/releases)
- [Commits](cookpad/omniauth-rails_csrf_protection@v1.0.1...v1.0.2)

---
updated-dependencies:
- dependency-name: omniauth-rails_csrf_protection
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Orner <[email protected]>
Bumps [rubocop-performance](https://github.com/rubocop/rubocop-performance) from 1.20.2 to 1.21.0.
- [Release notes](https://github.com/rubocop/rubocop-performance/releases)
- [Changelog](https://github.com/rubocop/rubocop-performance/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-performance@v1.20.2...v1.21.0)

---
updated-dependencies:
- dependency-name: rubocop-performance
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [nokogiri](https://github.com/sparklemotion/nokogiri) from 1.16.4 to 1.16.5.
- [Release notes](https://github.com/sparklemotion/nokogiri/releases)
- [Changelog](https://github.com/sparklemotion/nokogiri/blob/main/CHANGELOG.md)
- [Commits](sparklemotion/nokogiri@v1.16.4...v1.16.5)

---
updated-dependencies:
- dependency-name: nokogiri
  dependency-type: direct:production
  update-type: version-update:semver-patch
...

Signed-off-by: dependabot[bot] <[email protected]>
Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Co-authored-by: Daniel Orner <[email protected]>
Spec looked for a certain amount of the value '50' on the page
if the bank was name Bank 50 or Bank 150 the test would fail.

Set a unique name to ensure failures will not occur.
…by-county-spec

fix: flaky dist by county spec
Bumps [rubocop-rails](https://github.com/rubocop/rubocop-rails) from 2.24.1 to 2.25.0.
- [Release notes](https://github.com/rubocop/rubocop-rails/releases)
- [Changelog](https://github.com/rubocop/rubocop-rails/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop-rails@v2.24.1...v2.25.0)

---
updated-dependencies:
- dependency-name: rubocop-rails
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
Bumps [standard](https://github.com/standardrb/standard) and [rubocop](https://github.com/rubocop/rubocop). These dependencies needed to be updated together.

Updates `standard` from 1.35.1 to 1.36.0
- [Release notes](https://github.com/standardrb/standard/releases)
- [Changelog](https://github.com/standardrb/standard/blob/main/CHANGELOG.md)
- [Commits](standardrb/standard@v1.35.1...v1.36.0)

Updates `rubocop` from 1.62.1 to 1.63.5
- [Release notes](https://github.com/rubocop/rubocop/releases)
- [Changelog](https://github.com/rubocop/rubocop/blob/master/CHANGELOG.md)
- [Commits](rubocop/rubocop@v1.62.1...v1.63.5)

---
updated-dependencies:
- dependency-name: standard
  dependency-type: direct:development
  update-type: version-update:semver-minor
- dependency-name: rubocop
  dependency-type: direct:development
  update-type: version-update:semver-minor
...

Signed-off-by: dependabot[bot] <[email protected]>
* any remaining specs?

* refactor: remove skip_items

* refactor: remove seed_db false

* refactor: remove skip_seed

* fix: more skip_items

* fix: remove replace.sh

* fix: remove params
…man-essentials into 4175-add-request-type-flag
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.