copy rightItem uuid only if there is some value to add

avoids exception in nCopied method
uniba-ub · Nov 14, 2023 · 58a010b · 58a010b
1 parent 3bc0f1b
commit 58a010b
Showing 1 changed file with 12 additions and 4 deletions.
diff --git a/dspace-api/src/main/java/org/dspace/content/RelationshipPlacesIndexingServiceImpl.java b/dspace-api/src/main/java/org/dspace/content/RelationshipPlacesIndexingServiceImpl.java
@@ -55,7 +55,9 @@ public void updateRelationReferences(final Context context, final Relationship r
                 if (singleDirectionRelationship("right", relationship.getRelationshipType())) {
                     times = relation.getLeftPlace() - relation.getRightPlace();
                 }
-                rightItemsIdsToAdd.addAll(Collections.nCopies(times, relation.getRightItem().getID().toString()));
+                if (times > 0) {
+                    rightItemsIdsToAdd.addAll(Collections.nCopies(times, relation.getRightItem().getID().toString()));
+                }
             }
             if (!rightItemsIdsToAdd.isEmpty()) {
 
@@ -79,7 +81,9 @@ public void updateRelationReferences(final Context context, final Relationship r
                 if (singleDirectionRelationship("left", relationship.getRelationshipType())) {
                     times = relation.getRightPlace() - relation.getLeftPlace();
                 }
-                leftItemsIdsToAdd.addAll(Collections.nCopies(times, relation.getLeftItem().getID().toString()));
+                if (times > 0) {
+                    leftItemsIdsToAdd.addAll(Collections.nCopies(times, relation.getLeftItem().getID().toString()));
+                }
             }
             if (!leftItemsIdsToAdd.isEmpty()) {
 
@@ -102,7 +106,9 @@ private void addRightItemsReferences(final Context context, final Relationship r
             if (singleDirectionRelationship("right", relationship.getRelationshipType())) {
                 times = leftItemRelation.getLeftPlace() - leftItemRelation.getRightPlace();
             }
-            rightItemsToAdd.addAll(Collections.nCopies(times, leftItemRelation.getRightItem().getID().toString()));
+            if (times > 0) {
+                rightItemsToAdd.addAll(Collections.nCopies(times, leftItemRelation.getRightItem().getID().toString()));
+            }
         }
         if (!rightItemsToAdd.isEmpty())  {
             indexingService.updateRelationForItem(leftItem.getID().toString(),
@@ -122,7 +128,9 @@ private void addLeftItemsReferences(final Context context, final Relationship re
             if (singleDirectionRelationship("left", relationship.getRelationshipType())) {
                 times = leftItemRelation.getRightPlace() - leftItemRelation.getLeftPlace();
             }
-            rightItemsToAdd.addAll(Collections.nCopies(times, leftItemRelation.getLeftItem().getID().toString()));
+            if (times > 0) {
+                rightItemsToAdd.addAll(Collections.nCopies(times, leftItemRelation.getLeftItem().getID().toString()));
+            }
         }
         if (!rightItemsToAdd.isEmpty())  {
             indexingService.updateRelationForItem(rightItem.getID().toString(),