CLDR-18220 Dashboard Other category for all other paths #4273
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -402,7 +402,7 @@ private static Dashboard.ReviewNotification[] getOnePathDash( | |||||
| String baseXp, CLDRLocale locale, CookieSession mySession) { | ||||||
| Level coverageLevel = Level.get(mySession.getEffectiveCoverageLevel(locale.toString())); | ||||||
| Dashboard.ReviewOutput ro = | ||||||
| new Dashboard().get(locale, mySession.user, coverageLevel, baseXp, false); | ||||||
|
There was a problem hiding this comment. Same nit
Suggested change
|
||||||
| return ro.getNotifications(); | ||||||
| } | ||||||
|
|
||||||
|
|
||||||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -57,7 +57,8 @@ public enum NotificationCategory { | |
|
|
||
| /** You have abstained, or not yet voted for any value */ | ||
| abstained('A', "Abstained", "You have abstained, or not yet voted for any value."), | ||
|
|
||
| other('O', "Other", "All other values"); | ||
|
Comment on lines
-60
to
+61
There was a problem hiding this comment. Since it's without errors, warnings and it isn't abstained, that this group should be thought of as "voted, no issues"? To keep the name minimal we can call it other, but I wonder if we should make it clearer. There was a problem hiding this comment.
|
||
|
|
||
| public final char abbreviation; | ||
| public final String buttonLabel; | ||
|
|
||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -480,37 +480,45 @@ private void handleOnePath(String path) { | |
| (baselineFileUnresolved == null) | ||
| ? null | ||
| : baselineFileUnresolved.getWinningValue(path); | ||
| final boolean skip = skipForLimitedSubmission(path, errorStatus, oldValue); | ||
| if (!skip) { | ||
| if (!onlyRecordErrors | ||
| && choices.contains(NotificationCategory.changedOldValue) | ||
| && changedFromBaseline(path, value, oldValue, sourceFile)) { | ||
| problems.add(NotificationCategory.changedOldValue); | ||
| vc.problemCounter.increment(NotificationCategory.changedOldValue); | ||
| } | ||
| if (!onlyRecordErrors | ||
| && choices.contains(NotificationCategory.inheritedChanged) | ||
| && inheritedChangedFromBaseline(path, value, sourceFile)) { | ||
| problems.add(NotificationCategory.inheritedChanged); | ||
| vc.problemCounter.increment(NotificationCategory.inheritedChanged); | ||
| } | ||
| VoteResolver.VoteStatus voteStatus = | ||
| userVoteStatus.getStatusForUsersOrganization( | ||
| sourceFile, path, organization); | ||
| boolean itemsOkIfVoted = (voteStatus == VoteResolver.VoteStatus.ok); | ||
| MissingStatus missingStatus = | ||
| onlyRecordErrors | ||
| ? null | ||
| : recordMissingChangedEtc(path, itemsOkIfVoted, value, oldValue); | ||
| recordChoice(errorStatus, itemsOkIfVoted, onlyRecordErrors); | ||
| if (!onlyRecordErrors) { | ||
| recordLosingDisputedEtc(path, voteStatus, missingStatus); | ||
| } | ||
| } | ||
| // add the catch-all value | ||
| if (!pathLevelIsTooHigh | ||
| && problems.isEmpty() | ||
| && choices.contains(NotificationCategory.other)) { | ||
| problems.add(NotificationCategory.other); | ||
| } | ||
| if (pathLevelIsTooHigh && problems.isEmpty()) { | ||
| return; | ||
| } | ||
| if (!skip) { | ||
| updateVotedOrAbstained(path); | ||
| } | ||
| if (!problems.isEmpty() && sorted != null) { | ||
| reasonsToPaths.clear(); | ||
| R2<SectionId, PageId> group = Row.of(ph.getSectionId(), ph.getPageId()); | ||
|
|
@@ -1705,9 +1713,9 @@ public static void getStatus( | |
|
|
||
| public static EnumSet<NotificationCategory> getDashboardNotificationCategories( | ||
| Organization usersOrg) { | ||
| EnumSet<NotificationCategory> choices = EnumSet.allOf(NotificationCategory.class); | ||
| if (orgIsNeutralForSummary(usersOrg)) { | ||
| choices = | ||
| EnumSet.of( | ||
| NotificationCategory.error, | ||
| NotificationCategory.warning, | ||
|
|
@@ -1716,14 +1724,16 @@ public static EnumSet<NotificationCategory> getDashboardNotificationCategories( | |
| NotificationCategory.missingCoverage); | ||
| // skip weLost, englishChanged, changedOldValue, abstained | ||
| } | ||
| choices.remove(NotificationCategory.other); // expect this one to be added explicitly | ||
| return choices; | ||
| } | ||
|
|
||
| public static EnumSet<NotificationCategory> getPriorityItemsSummaryCategories( | ||
| Organization org) { | ||
| EnumSet<NotificationCategory> choices = getDashboardNotificationCategories(org); | ||
| choices.remove(NotificationCategory.abstained); | ||
| choices.remove(NotificationCategory.other); // expect this one to be added explicitly | ||
| return choices; | ||
| } | ||
|
|
||
| public static EnumSet<NotificationCategory> getLocaleCompletionCategories() { | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion for future improvement: hover text for this control with brief explanation what it does, e.g., "Include notifications for ALL paths within the chosen coverage level that do not belong to another notification category. Note: the number of 'other' notifications may be very large"