Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(voyager): split out voyager-core #2999

Merged
merged 1 commit into from
Sep 23, 2024

feat(voyager): split out voyager-core

53a9403
Select commit
Loading
Failed to load commit list.
Merged

feat(voyager): split out voyager-core #2999

feat(voyager): split out voyager-core
53a9403
Select commit
Loading
Failed to load commit list.
Garnix CI / check clippy [x86_64-linux] succeeded Sep 21, 2024 in 7m 3s

Run results

Build succeeded

Details

Last 100 lines of logs:

383 +                 .latest_ledger_info()
384 +                 .commit_info
385 +                 .executed_state_id
386 ~                 .get(),
    |

warning: the borrowed expression implements the required traits
   --> light-clients/movement/ics08-movement/src/client.rs:455:13
    |
455 | /             &bcs::to_bytes(&PersistedStateValue::WithMetadata {
456 | |                 data: value.to_vec(),
457 | |                 metadata: PersistedStateValueMetadata::V1 {
458 | |                     slot_deposit: 40000,
...   |
462 | |             })
463 | |             .unwrap(),
    | |_____________________^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrows_for_generic_args
    = note: `#[warn(clippy::needless_borrows_for_generic_args)]` on by default
help: change this to
    |
455 ~             bcs::to_bytes(&PersistedStateValue::WithMetadata {
456 +                 data: value.to_vec(),
457 +                 metadata: PersistedStateValueMetadata::V1 {
458 +                     slot_deposit: 40000,
459 +                     bytes_deposit: 3600,
460 +                     creation_time_usecs: 1726830371849456,
461 +                 },
462 +             })
463 ~             .unwrap(),
    |

warning: `ics08-movement` (lib test) generated 13 warnings (run `cargo clippy --fix --lib -p ics08-movement --tests` to apply 8 suggestions)
    Checking chain-utils v0.1.0 (/build/source/lib/chain-utils)
    Checking linea-verifier v0.1.0 (/build/source/lib/linea-verifier)
    Checking scroll-verifier v0.1.0 (/build/source/lib/scroll-verifier)
    Checking linea-light-client v0.1.0 (/build/source/light-clients/linea-light-client)
    Checking scroll-light-client v0.1.0 (/build/source/light-clients/scroll-light-client)
    Checking dummy-ibc-app v0.1.0 (/build/source/lib/near/dummy-ibc-app)
    Checking near-light-client v0.1.0 (/build/source/lib/near/near-light-client)
    Checking near-ibc v0.1.0 (/build/source/lib/near/near-ibc)
    Checking voyager-message v0.1.0 (/build/source/lib/voyager-message)
    Checking ucli v0.1.0 (/build/source/ucli)
    Checking hubble v0.1.0 (/build/source/hubble)
    Checking drip v0.1.0 (/build/source/drip)
    Checking voyager-consensus-module-ethereum v0.1.0 (/build/source/voyager/modules/consensus/ethereum)
    Checking voyager-consensus-module-cometbls v0.1.0 (/build/source/voyager/modules/consensus/cometbls)
    Checking voyager-consensus-module-movement v0.1.0 (/build/source/voyager/modules/consensus/movement)
    Checking voyager-plugin-transaction-batch v0.1.0 (/build/source/voyager/plugins/transaction-batch)
    Checking voyager-client-module-movement v0.1.0 (/build/source/voyager/modules/client/movement)
    Checking voyager-client-module-ethereum v0.1.0 (/build/source/voyager/modules/client/ethereum)
    Checking voyager-transaction-module-ethereum v0.1.0 (/build/source/voyager/modules/transaction/ethereum)
    Checking voyager v0.1.0 (/build/source/voyager)
    Checking voyager-transaction-module-aptos v0.1.0 (/build/source/voyager/modules/transaction/aptos)
    Checking voyager-chain-module-cosmos-sdk v0.1.0 (/build/source/voyager/modules/chain/cosmos-sdk)
    Checking voyager-client-module-cometbls v0.1.0 (/build/source/voyager/modules/client/cometbls)
    Checking voyager-plugin-packet-filter v0.1.0 (/build/source/voyager/plugins/packet-filter)
    Checking voyager-transaction-module-cosmos-sdk v0.1.0 (/build/source/voyager/modules/transaction/cosmos-sdk)
    Checking voyager-chain-module-movement v0.1.0 (/build/source/voyager/modules/chain/movement)
    Checking voyager-chain-module-ethereum v0.1.0 (/build/source/voyager/modules/chain/ethereum)
warning: unused variable: `cmd`
   --> voyager/modules/chain/movement/src/main.rs:145:29
    |
145 |     pub async fn cmd(&self, cmd: Cmd) -> Result<(), BoxDynError> {
    |                             ^^^ help: if this is intentional, prefix it with an underscore: `_cmd`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: unused variable: `resp`
   --> voyager/modules/consensus/movement/src/main.rs:353:9
    |
353 |     let resp: StateProofResponse = serde_json::from_str(res).unwrap();
    |         ^^^^ help: if this is intentional, prefix it with an underscore: `_resp`
    |
    = note: `#[warn(unused_variables)]` on by default

warning: unused `std::result::Result` that must be used
   --> voyager/modules/consensus/movement/src/main.rs:345:9
    |
345 |         dbg!(res);
    |         ^^^^^^^^^
    |
    = note: this `Result` may be an `Err` variant, which should be handled
    = note: `#[warn(unused_must_use)]` on by default
    = note: this warning originates in the macro `dbg` (in Nightly builds, run with -Z macro-backtrace for more info)

warning: `voyager-consensus-module-movement` (bin "voyager-consensus-module-movement" test) generated 2 warnings
warning: `voyager-chain-module-movement` (bin "voyager-chain-module-movement" test) generated 1 warning
    Finished `release` profile [optimized] target(s) in 1m 29s
buildPhase completed in 1 minutes 30 seconds
Running phase: installPhase
@nix {"action":"setPhase","phase":"installPhase"}
linking previous artifacts /nix/store/48yvq0dlaas5ga87hic2kd4m8vawz9k0-workspace-cargo-clippy-deps-0.0.0/target.tar.zst to /nix/store/vm71fxxbdwnc7bgma8sgxbjllqzp2rg8-workspace-cargo-clippy-clippy-0.0.0/target.tar.zst
/*stdin*\            : 32.56%   (   107 MiB =>   34.8 MiB, /nix/store/vm71fxxbdwnc7bgma8sgxbjllqzp2rg8-workspace-cargo-clippy-clippy-0.0.0/target.tar.zst) 
Running phase: fixupPhase
@nix {"action":"setPhase","phase":"fixupPhase"}
shrinking RPATHs of ELF executables and libraries in /nix/store/vm71fxxbdwnc7bgma8sgxbjllqzp2rg8-workspace-cargo-clippy-clippy-0.0.0
checking for references to /build/ in /nix/store/vm71fxxbdwnc7bgma8sgxbjllqzp2rg8-workspace-cargo-clippy-clippy-0.0.0...
patching script interpreter paths in /nix/store/vm71fxxbdwnc7bgma8sgxbjllqzp2rg8-workspace-cargo-clippy-clippy-0.0.0