Fix bug in scratch file updates #4414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The system temp directory could be a different device (like a tmpfs), which would cause renameFile to fail since we are attempting to rename across device boundaries. To avoid this issue, create the temp file in the same directory as the unison scratch file that we will update.
|
Ah good catch. |
aryairani
approved these changes
Nov 22, 2023
aryairani
added
the
ready-to-merge
mergify
bot
removed
the
ready-to-merge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The system temp directory could be a different device (like a tmpfs), which would cause renameFile to fail since we are attempting to rename across device boundaries. To avoid this issue, create the temp file in the same directory as the unison scratch file that we will update.
Test coverage
manual