Lutaml-Model integration for YAML and XML processing #27
+986
−365
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
suleman-uzair
changed the title
ronaldtse
reviewed
Jan 23, 2025
lib/unitsml/xml/dimension.rb
Outdated
| require "unitsml/xml/dimension_quantities/plane_angle" | ||
|
|
||
| module Unitsml | ||
| module Xml |
There was a problem hiding this comment.
Why do we need a namespace Xml? The point of lutaml-model is to simplify this into a class that is format-agnostic, so we can also have a "UnitsML version in YAML".
There was a problem hiding this comment.
@ronaldtse, you are right, I’ll update this to model.
added dependent-gems workflow
suleman-uzair
force-pushed
the
feature/unitsdb_ruby_integration
branch
from
350c93c to
0942016
Compare
suleman-uzair
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR integrates Unitsdb-Ruby for Unitsdb content processing.
Additionally, it supports processing of XML and MathML using Lutaml-Model classes.
closes #21