Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pog TLD #329

Merged
merged 1 commit into from
Apr 3, 2024
Merged

Add pog TLD #329

merged 1 commit into from
Apr 3, 2024

Conversation

DeRain
Copy link
Contributor

@DeRain DeRain commented Apr 3, 2024

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@DeRain DeRain requested a review from a team April 3, 2024 15:12
@DeRain DeRain self-assigned this Apr 3, 2024
Copy link

github-actions bot commented Apr 3, 2024

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 19.75 +0.026
ProxyReader 15.176 0
UNSRegistry 20.725 0

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.73%. Comparing base (71de52c) to head (e781a8e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #329   +/-   ##
=======================================
  Coverage   98.73%   98.73%           
=======================================
  Files          21       21           
  Lines        1111     1111           
  Branches      246      246           
=======================================
  Hits         1097     1097           
  Misses         14       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@DeRain DeRain merged commit 18a403e into main Apr 3, 2024
8 checks passed
@DeRain DeRain deleted the add-pog-tld branch April 3, 2024 15:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants