Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1273] - create seaport proxy buyer smart contract #338

Merged
merged 23 commits into from
May 28, 2024

Conversation

DeRain
Copy link
Contributor

@DeRain DeRain commented May 10, 2024

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@DeRain DeRain requested a review from a team May 10, 2024 07:40
.nvmrc Outdated Show resolved Hide resolved
@nickshatilo
Copy link
Member

@DeRain please don't add dist/* files into the PR, it makes it harder to review 🙏 they are also re-compiled on the release stage on the CI, so there is no need

@nickshatilo
Copy link
Member

@DeRain A couple of things to add:

  • Deployment script for the new contract
  • Ensure it's added to sandbox, uns-config.json is updated

@nickshatilo
Copy link
Member

@DeRain could you please do git reset --hard origin/main -- dist/* ? My browser struggles to load the diff here....

@DeRain DeRain requested a review from a team May 21, 2024 17:15
@DeRain
Copy link
Contributor Author

DeRain commented May 21, 2024

Need to install foundry and anvil inside GitHub actions workspace to avoid errors in CI

@nickshatilo
Copy link
Member

outstanding job with anvil! 🚀 @DeRain

@DeRain DeRain requested a review from a team May 24, 2024 09:54
tsconfig.json Outdated Show resolved Hide resolved
@nickshatilo
Copy link
Member

a few minor touches, but overall LGTM

@DeRain DeRain requested review from nickshatilo and a team May 28, 2024 11:21
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 19.781 0
ProxyReader 15.176 0
UNSRegistry 20.725 0

@DeRain DeRain merged commit 7b625f4 into main May 28, 2024
8 checks passed
@DeRain DeRain deleted the kiryl/reg-1273-create-seaport-proxy-buyer-smart-contract branch May 28, 2024 14:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants