Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1332] feat: move uns tlds minting config outside of minting manager #351

Merged

Conversation

roman-gnativ
Copy link
Contributor

PR Checklist

Linear ticket:
https://linear.app/unstoppable-domains/issue/REG-1332/introduce-tld-configs-in-uns-repo

Background:
To deploy our registry contracts to the base chain, we have made UNS contracts unified across chains, which, in the case of the base chain, means removing the TLD config outside the minting manager contract.

What was done:

  • Tld config removed from the Minting manager smart contract
  • Tld config introduced in the uns repo
  • Added a deployment task that mints all TLDs from the TLD config

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@roman-gnativ roman-gnativ requested a review from a team July 29, 2024 09:51
@roman-gnativ roman-gnativ self-assigned this Jul 29, 2024
src/helpers.ts Outdated Show resolved Hide resolved
src/helpers.ts Outdated Show resolved Hide resolved
@nickshatilo
Copy link
Member

overall LGTM @roman-gnativ, just a few naming / structure suggestions

@@ -73,45 +73,45 @@
"1337": {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please increase version of ens-config

"legacyAddresses": [],
"deploymentBlock": "0x32"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 18.92 -1.136
ProxyReader 15.176 0
UNSRegistry 20.725 0

@roman-gnativ roman-gnativ merged commit 3968ed9 into main Aug 19, 2024
8 checks passed
@roman-gnativ roman-gnativ deleted the romangnativ/reg-1332-introduce-tld-config-in-uns-repo branch August 19, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants