-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REG-1332] feat: move uns tlds minting config outside of minting manager #351
Merged
roman-gnativ
merged 7 commits into
main
from
romangnativ/reg-1332-introduce-tld-config-in-uns-repo
Aug 19, 2024
Merged
[REG-1332] feat: move uns tlds minting config outside of minting manager #351
roman-gnativ
merged 7 commits into
main
from
romangnativ/reg-1332-introduce-tld-config-in-uns-repo
Aug 19, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DeRain
approved these changes
Jul 30, 2024
nickshatilo
reviewed
Jul 31, 2024
nickshatilo
reviewed
Jul 31, 2024
nickshatilo
reviewed
Jul 31, 2024
nickshatilo
reviewed
Jul 31, 2024
nickshatilo
reviewed
Jul 31, 2024
overall LGTM @roman-gnativ, just a few naming / structure suggestions |
nickshatilo
approved these changes
Aug 16, 2024
nickshatilo
reviewed
Aug 16, 2024
@@ -73,45 +73,45 @@ | |||
"1337": { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please increase version of ens-config
nickshatilo
reviewed
Aug 16, 2024
"legacyAddresses": [], | ||
"deploymentBlock": "0x32" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Contracts size report
|
roman-gnativ
deleted the
romangnativ/reg-1332-introduce-tld-config-in-uns-repo
branch
August 19, 2024 10:15
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Linear ticket:
https://linear.app/unstoppable-domains/issue/REG-1332/introduce-tld-configs-in-uns-repo
Background:
To deploy our registry contracts to the base chain, we have made UNS contracts unified across chains, which, in the case of the base chain, means removing the TLD config outside the minting manager contract.
What was done:
1. Contracts versioning
patch
version of the contracts is increased if changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts.minor
version of the contracts is increased if breaking changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.json
is increased if changes have been made to the config.ens-config.json
is increased if changes have been made to the config.resolver-keys.json
is increased if changes have been made to the config.ens-resolver-keys.json
is increased if changes have been made to the config.5. Package versioning
patch
version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minor
version of package is synced with version ofUNSRegistry
contract.CHANGELOG
is updated with short description for the new version.6. Code review
resolver-keys.json
code review is required from DevTools teamens-resolver-keys.json
code review is required from DevTools team