Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[REG-1333] feat: deploy uns to base sepolia #352

Merged
merged 14 commits into from
Aug 19, 2024

Conversation

roman-gnativ
Copy link
Contributor

@roman-gnativ roman-gnativ commented Aug 1, 2024

Linear ticket:
https://linear.app/unstoppable-domains/issue/REG-1333/deploy-the-base-registry-to-base-sepolia-network

Background:
UNS is now deployed to Base sepolia. That includes these smart contracts:

  • ProxyAdmin
  • UNSRegistry
  • MintingManager
  • UNSOperator
  • ProxyReader
  • SeaportProxyBuyer

Some things are blocked by work on the web side, so we are still missing some items that should be done:

PR Checklist

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@roman-gnativ roman-gnativ requested a review from a team August 1, 2024 16:46
@roman-gnativ roman-gnativ self-assigned this Aug 1, 2024
@roman-gnativ roman-gnativ changed the title [REG-1332] feat: deploy uns to base sepolia [REG-1333] feat: deploy uns to base sepolia Aug 5, 2024
@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (romangnativ/reg-1332-introduce-tld-config-in-uns-repo@c8c63aa). Learn more about missing BASE report.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@                                   Coverage Diff                                    @@
##             romangnativ/reg-1332-introduce-tld-config-in-uns-repo     #352   +/-   ##
========================================================================================
  Coverage                                                         ?   98.59%           
========================================================================================
  Files                                                            ?       22           
  Lines                                                            ?     1141           
  Branches                                                         ?      256           
========================================================================================
  Hits                                                             ?     1125           
  Misses                                                           ?       16           
  Partials                                                         ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nickshatilo
Copy link
Member

please also add changelog entry and increase the version in package.json

Base automatically changed from romangnativ/reg-1332-introduce-tld-config-in-uns-repo to main August 19, 2024 10:15
Copy link

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 18.92 0
ProxyReader 15.176 0
UNSRegistry 20.725 0

@roman-gnativ roman-gnativ merged commit e22366b into main Aug 19, 2024
6 of 7 checks passed
@roman-gnativ roman-gnativ deleted the romangnativ/reg-1333-deploy-uns-to-base-sepolia branch August 19, 2024 13:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants