-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[REG-1333] feat: deploy uns to base sepolia #352
[REG-1333] feat: deploy uns to base sepolia #352
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## romangnativ/reg-1332-introduce-tld-config-in-uns-repo #352 +/- ##
========================================================================================
Coverage ? 98.59%
========================================================================================
Files ? 22
Lines ? 1141
Branches ? 256
========================================================================================
Hits ? 1125
Misses ? 16
Partials ? 0 ☔ View full report in Codecov by Sentry. |
…into romangnativ/reg-1333-deploy-uns-to-base-sepolia
please also add changelog entry and increase the version in package.json |
Contracts size report
|
Linear ticket:
https://linear.app/unstoppable-domains/issue/REG-1333/deploy-the-base-registry-to-base-sepolia-network
Background:
UNS is now deployed to Base sepolia. That includes these smart contracts:
Some things are blocked by work on the web side, so we are still missing some items that should be done:
https://linear.app/unstoppable-domains/issue/REG-1333/deploy-the-base-registry-to-base-sepolia-network
PR Checklist
1. Contracts versioning
patch
version of the contracts is increased if changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts.minor
version of the contracts is increased if breaking changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.json
is increased if changes have been made to the config.ens-config.json
is increased if changes have been made to the config.resolver-keys.json
is increased if changes have been made to the config.ens-resolver-keys.json
is increased if changes have been made to the config.5. Package versioning
patch
version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minor
version of package is synced with version ofUNSRegistry
contract.CHANGELOG
is updated with short description for the new version.6. Code review
resolver-keys.json
code review is required from DevTools teamens-resolver-keys.json
code review is required from DevTools team