Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reg-1395] Adjust seaport proxy buyer smart contract to support zone interface and allow any order #360

Conversation

Armen-Arakelian
Copy link
Contributor

@Armen-Arakelian Armen-Arakelian commented Sep 9, 2024

PR Checklist

Description

Added new workflow for matching marketplace orders - matchOrders. According to recent marketplace logic changes, users now available to create both "sides" orders, meaning to sell domain or to buy domain. If we find 2 fulfilling orders we now can match them from any caller using matchAdvancedOrders function on Seaport core SC. SeaportProxyBuyer acts as a zone in this case, authorazing and validating those orders. It is essential that it contains both functions.

1. Contracts versioning

  • Make sure that the patch version of the contracts is increased if changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts.
  • Make sure that the minor version of the contracts is increased if breaking changes have been made to the UNSRegistry, MintingManager, ProxyReader, ENSCustody contracts. It includes changes of interfaces.

2. Contracts licensing

  • Make sure that no SPDX-License-Identifier defined in contracts.
  • Make sure that the header is added to the new contract files.
    // @author Unstoppable Domains, Inc.
    // @date {Month} {Day}(ordinal), {Year}
    

3. Coverage

  • Make sure that the coverage of contracts has not decreased and strive 100%

4. Configs versioning

  • Make sure that the version of uns-config.json is increased if changes have been made to the config.
  • Make sure that the version of ens-config.json is increased if changes have been made to the config.
  • Make sure that the version of resolver-keys.json is increased if changes have been made to the config.
  • Make sure that the version of ens-resolver-keys.json is increased if changes have been made to the config.

5. Package versioning

  • Make sure that the patch version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.
  • Make sure that the major.minor version of package is synced with version of UNSRegistry contract.
  • Make sure that the CHANGELOG is updated with short description for the new version.

6. Code review

  • resolver-keys.json code review is required from DevTools team
  • ens-resolver-keys.json code review is required from DevTools team
  • For all other changes code review is required from Registry team

@Armen-Arakelian Armen-Arakelian requested review from DeRain, nickshatilo and a team September 9, 2024 13:48
Copy link

github-actions bot commented Sep 9, 2024

Contracts size report

Contract name Size (KiB) Delta (KiB)
ENSCustody 13.063 0
MintingManager 18.92 0
ProxyReader 15.176 0
UNSRegistry 20.725 0

@Armen-Arakelian Armen-Arakelian marked this pull request as ready for review September 9, 2024 17:31
Copy link
Member

@nickshatilo nickshatilo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but would defer to @DeRain for final approval

@Armen-Arakelian Armen-Arakelian self-assigned this Sep 10, 2024
@Armen-Arakelian Armen-Arakelian changed the title Reg 1395/adjust seaport proxy buyer smart contract to support zone interface and allow any order [Reg-1395] Adjust seaport proxy buyer smart contract to support zone interface and allow any order Sep 10, 2024
Copy link
Contributor

@DeRain DeRain left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job! Thank you for fixing linters and prettier.

@Armen-Arakelian Armen-Arakelian merged commit d43ca42 into main Sep 10, 2024
8 checks passed
@Armen-Arakelian Armen-Arakelian deleted the REG-1395/Adjust-SeaportProxyBuyer-smart-contract-to-support-ZoneInterface-and-allow-any-order branch September 10, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants