-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Reg-1395] Adjust seaport proxy buyer smart contract to support zone interface and allow any order #360
Merged
Armen-Arakelian
merged 8 commits into
main
from
REG-1395/Adjust-SeaportProxyBuyer-smart-contract-to-support-ZoneInterface-and-allow-any-order
Sep 10, 2024
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contracts size report
|
nickshatilo
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but would defer to @DeRain for final approval
Armen-Arakelian
changed the title
Reg 1395/adjust seaport proxy buyer smart contract to support zone interface and allow any order
[Reg-1395] Adjust seaport proxy buyer smart contract to support zone interface and allow any order
Sep 10, 2024
DeRain
approved these changes
Sep 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great job! Thank you for fixing linters and prettier.
Armen-Arakelian
deleted the
REG-1395/Adjust-SeaportProxyBuyer-smart-contract-to-support-ZoneInterface-and-allow-any-order
branch
September 10, 2024 14:31
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Description
Added new workflow for matching marketplace orders - matchOrders. According to recent marketplace logic changes, users now available to create both "sides" orders, meaning to sell domain or to buy domain. If we find 2 fulfilling orders we now can match them from any caller using matchAdvancedOrders function on Seaport core SC. SeaportProxyBuyer acts as a zone in this case, authorazing and validating those orders. It is essential that it contains both functions.
1. Contracts versioning
patch
version of the contracts is increased if changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts.minor
version of the contracts is increased if breaking changes have been made to theUNSRegistry
,MintingManager
,ProxyReader
,ENSCustody
contracts. It includes changes of interfaces.2. Contracts licensing
3. Coverage
4. Configs versioning
uns-config.json
is increased if changes have been made to the config.ens-config.json
is increased if changes have been made to the config.resolver-keys.json
is increased if changes have been made to the config.ens-resolver-keys.json
is increased if changes have been made to the config.5. Package versioning
patch
version of package is increased if valuable changes have been made to the package. It includes contracts update, configs update, etc.major.minor
version of package is synced with version ofUNSRegistry
contract.CHANGELOG
is updated with short description for the new version.6. Code review
resolver-keys.json
code review is required from DevTools teamens-resolver-keys.json
code review is required from DevTools team