-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adc driver #7
Merged
Merged
Adc driver #7
Changes from 1 commit
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
7a6a70d
Add adc crate init.
NoahSprenger d07ef83
WIP: Init driver
NoahSprenger 7c1af85
Convert RREG and WREG to use Register not u8
BLM16 48c63fd
Added getters and setters for ID, POWER, and INTERFACE registers
BLM16 645acec
Rename read_register to read_multiple_registers. Remove call to read_…
NoahSprenger 1f0417c
Update doc
NoahSprenger f261ee8
Converted WREG to single and multiple variant
BLM16 fe7fa31
Added set_crc and removed RESERVED from Crc enum
BLM16 6437ec7
Convert CRC from enum to bitflag
BLM16 ea70a00
Moved status register to register module
BLM16 2621498
Added MODE register impls
BLM16 adea264
Added more registers
BLM16 d50bebc
Removed redundant StatusRegister impl block
BLM16 27e7134
Added more registers
BLM16 ff34e4a
Implemented last registers
BLM16 ca58815
Align Register values
BLM16 4908acd
Start init and add default example to Mode2Register.
NoahSprenger 840a32d
Add default constructors to registers.
NoahSprenger 6d2ce9f
Rework driver to avoid taking ownership of spi peripheral.
NoahSprenger fcf04c9
Change path to git path for HAL import.
NoahSprenger 2f99606
Create temperature board adc manager.
NoahSprenger 9d80d85
Add ADC manager to all boards.
NoahSprenger File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is added since normally one would call a Delay object from the HAL that is clocked by SysTick to delay when needed, but RTIC consumes SysTick. Not feasible (IMO) to propagate RTIC delays down to this level. Possible that an implementation of Delay could be created with a clock object instead of SysTick but I haven't look into this in depth.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is delay in μs, and is
nop
guaranteed to take precisely 1 clock cycle? Ifnop
takes 1 clock cycle, then we'd need to go 0..(delay * cycles/delay_unit_of_time) no?