Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleanup #9

Merged
merged 3 commits into from
Dec 29, 2024
Merged

Cleanup #9

merged 3 commits into from
Dec 29, 2024

Conversation

NoahSprenger
Copy link
Contributor

@NoahSprenger NoahSprenger commented Dec 29, 2024

This pull request includes significant changes to the boards/pressure and boards/strain directories, primarily involving the removal of various modules and dependencies. The most important changes include the removal of the Cargo.toml files, the AdcManager, CanCommandManager, CanDataManager, RadioDevice, RadioManager, DataManager, and COM_ID definitions.

Dependency and configuration removals:

Module removals:

};

// Why?
can.set_protocol_exception_handling(false);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is left over from hydra since I wanted to dump CAN messages as fast as possible and this was a performance improvement.

Copy link
Member

@BLM16 BLM16 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks much cleaner. I agree that building out from the one crate to reuse as much functionality as possible is best. The refactoring seems good as well, so provided this is the direction we are going to take, these changes look good.

@NoahSprenger NoahSprenger merged commit da03179 into master Dec 29, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants