Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

create recovery timer mechanism #101

Merged
merged 12 commits into from
Jun 8, 2024

clear interrupts

5249e30
Select commit
Loading
Failed to load commit list.
Sign in for the full log view
Merged

create recovery timer mechanism #101

clear interrupts
5249e30
Select commit
Loading
Failed to load commit list.
GitHub Actions / clippy succeeded May 4, 2024 in 1s

clippy

90 warnings

Details

Results

Message level Amount
Internal compiler error 0
Error 0
Warning 90
Note 0
Help 0

Versions

  • rustc 1.78.0 (9b00956e5 2024-04-29)
  • cargo 1.78.0 (54d8815d0 2024-03-26)
  • clippy 0.1.78 (9b00956 2024-04-29)

Annotations

Check warning on line 64 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
  --> boards/sensor_v2/src/main.rs:64:9
   |
64 |         loop {}
   |         ^^^^^^^
   |
   = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
   = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 26 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

field `data_manager` is never read

warning: field `data_manager` is never read
  --> boards/sensor_v2/src/main.rs:26:9
   |
26 |         data_manager: DataManager,
   |         ^^^^^^^^^^^^
...
35 |     fn init(mut ctx: init::Context) -> (SharedResources, LocalResources, init::Monotonics) {
   |                                         --------------- field in this struct

Check warning on line 32 in boards/sensor_v2/src/data_manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

methods `clone_sensors` and `handle_data` are never used

warning: methods `clone_sensors` and `handle_data` are never used
  --> boards/sensor_v2/src/data_manager.rs:32:12
   |
19 | impl DataManager {
   | ---------------- methods in this implementation
...
32 |     pub fn clone_sensors(&self) -> [Option<SensorData>; 10] {
   |            ^^^^^^^^^^^^^
...
47 |     pub fn handle_data(&mut self, data: Message) -> Result<(), HydraError> {
   |            ^^^^^^^^^^^
   |
   = note: `#[warn(dead_code)]` on by default

Check warning on line 68 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
  --> boards/sensor_v2/src/main.rs:68:21
   |
68 |     fn sleep_system(mut cx: sleep_system::Context) {
   |                     ----^^
   |                     |
   |                     help: remove this `mut`

Check warning on line 68 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `cx`

warning: unused variable: `cx`
  --> boards/sensor_v2/src/main.rs:68:25
   |
68 |     fn sleep_system(mut cx: sleep_system::Context) {
   |                         ^^ help: if this is intentional, prefix it with an underscore: `_cx`

Check warning on line 63 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
  --> boards/sensor_v2/src/main.rs:63:13
   |
63 |     fn idle(mut ctx: idle::Context) -> ! {
   |             ----^^^
   |             |
   |             help: remove this `mut`

Check warning on line 63 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `ctx`

warning: unused variable: `ctx`
  --> boards/sensor_v2/src/main.rs:63:17
   |
63 |     fn idle(mut ctx: idle::Context) -> ! {
   |                 ^^^ help: if this is intentional, prefix it with an underscore: `_ctx`

Check warning on line 49 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
  --> boards/sensor_v2/src/main.rs:49:13
   |
49 |         let mut button = gpioc.pc13.into_floating_input();
   |             ----^^^^^^
   |             |
   |             help: remove this `mut`

Check warning on line 35 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

variable does not need to be mutable

warning: variable does not need to be mutable
  --> boards/sensor_v2/src/main.rs:35:13
   |
35 |     fn init(mut ctx: init::Context) -> (SharedResources, LocalResources, init::Monotonics) {
   |             ----^^^
   |             |
   |             help: remove this `mut`
   |
   = note: `#[warn(unused_mut)]` on by default

Check warning on line 16 in boards/sensor_v2/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused variable: `info`

warning: unused variable: `info`
  --> boards/sensor_v2/src/main.rs:16:10
   |
16 | fn panic(info: &core::panic::PanicInfo) -> ! {
   |          ^^^^ help: if this is intentional, prefix it with an underscore: `_info`
   |
   = note: `#[warn(unused_variables)]` on by default

Check warning on line 74 in boards/communication/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> boards/communication/src/main.rs:60:21
   |
60 |           sd_manager: SdManager<
   |  _____________________^
61 | |             Spi<
62 | |                 Config<
63 | |                     Pads<
...  |
73 | |             Pin<PB14, Output<PushPull>>,
74 | |         >,
   | |_________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity

Check warning on line 253 in boards/communication/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> boards/communication/src/main.rs:253:42
    |
253 |                 manager.write(&mut file, &msg_ser)?;
    |                                          ^^^^^^^^ help: change this to: `msg_ser`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow

Check warning on line 250 in boards/communication/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this expression creates a reference which is immediately dereferenced by the compiler

warning: this expression creates a reference which is immediately dereferenced by the compiler
   --> boards/communication/src/main.rs:250:42
    |
250 |                 manager.write(&mut file, &msg_ser)?;
    |                                          ^^^^^^^^ help: change this to: `msg_ser`
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_borrow
    = note: `#[warn(clippy::needless_borrow)]` on by default

Check warning on line 200 in boards/communication/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/communication/src/main.rs:200:9
    |
200 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 70 in boards/communication/src/health.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (11/7)

warning: this function has too many arguments (11/7)
  --> boards/communication/src/health.rs:58:5
   |
58 | /     pub fn new(
59 | |         reader: Adc<ADC0>,
60 | |         reader1: Adc<ADC1>,
61 | |         pin_3v3: Pin<PB01, Alternate<B>>,
...  |
69 | |         pin_failover: Pin<PB05, Alternate<B>>,
70 | |     ) -> Self {
   | |_____________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments

Check warning on line 92 in /home/runner/work/hydra/hydra/libraries/common-arm/src/error/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unused `core::result::Result` that must be used

warning: unused `core::result::Result` that must be used
   --> boards/recovery/src/data_manager.rs:112:25
    |
112 |                         spawn!(recovery_counter_tick);
    |                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = note: this `Result` may be an `Err` variant, which should be handled
    = note: `#[warn(unused_must_use)]` on by default
    = note: this warning originates in the macro `spawn` (in Nightly builds, run with -Z macro-backtrace for more info)

Check warning on line 52 in boards/communication/src/data_manager.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
  --> boards/communication/src/data_manager.rs:52:9
   |
52 |         return RadioRate::Slow;
   |         ^^^^^^^^^^^^^^^^^^^^^^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
   |
52 -         return RadioRate::Slow;
52 +         RadioRate::Slow
   |

Check warning on line 311 in boards/communication/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> boards/communication/src/communication.rs:311:13
    |
311 |             return Err(mavlink::error::MessageReadError::Io.into());
    |             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
311 -             return Err(mavlink::error::MessageReadError::Io.into());
311 +             Err(mavlink::error::MessageReadError::Io.into())
    |

Check warning on line 307 in boards/communication/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> boards/communication/src/communication.rs:307:21
    |
307 |                     return Err(mavlink::error::MessageReadError::Io.into());
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
help: remove `return`
    |
307 -                     return Err(mavlink::error::MessageReadError::Io.into());
307 +                     Err(mavlink::error::MessageReadError::Io.into())
    |

Check warning on line 302 in boards/communication/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

unneeded `return` statement

warning: unneeded `return` statement
   --> boards/communication/src/communication.rs:302:21
    |
302 |                     return Ok(postcard::from_bytes::<Message>(&msg.message)?);
    |                     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
    = note: `#[warn(clippy::needless_return)]` on by default
help: remove `return`
    |
302 -                     return Ok(postcard::from_bytes::<Message>(&msg.message)?);
302 +                     Ok(postcard::from_bytes::<Message>(&msg.message)?)
    |

Check warning on line 81 in boards/communication/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> boards/communication/src/communication.rs:72:5
   |
72 | /     pub fn new<S>(
73 | |         can_rx: Pin<PA23, AlternateI>,
74 | |         can_tx: Pin<PA22, AlternateI>,
75 | |         pclk_can: Pclk<Can0, Gclk0Id>,
...  |
80 | |         loopback: bool,
81 | |     ) -> (Self, S::Inc)
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default

Check warning on line 67 in boards/communication/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

very complex type used. Consider factoring parts into `type` definitions

warning: very complex type used. Consider factoring parts into `type` definitions
  --> boards/communication/src/communication.rs:62:14
   |
62 |       pub can: Can<
   |  ______________^
63 | |         'static,
64 | |         Can0,
65 | |         Dependencies<Can0, Gclk0Id, Pin<PA23, Alternate<I>>, Pin<PA22, Alternate<I>>, CAN0>,
66 | |         Capacities,
67 | |     >,
   | |_____^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#type_complexity
   = note: `#[warn(clippy::type_complexity)]` on by default

Check warning on line 145 in boards/recovery/src/main.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

empty `loop {}` wastes CPU cycles

warning: empty `loop {}` wastes CPU cycles
   --> boards/recovery/src/main.rs:145:9
    |
145 |         loop {}
    |         ^^^^^^^
    |
    = help: you should either use `panic!()` or add a call pausing or sleeping the thread to the loop body
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#empty_loop
    = note: `#[warn(clippy::empty_loop)]` on by default

Check warning on line 106 in boards/recovery/src/state_machine/mod.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true

warning: an implementation of `From` is preferred since it gives you `Into<_>` for free where the reverse isn't true
   --> boards/recovery/src/state_machine/mod.rs:106:1
    |
106 | impl Into<state::StateData> for RocketStates {
    | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    |
    = help: `impl From<Local> for Foreign` is allowed by the orphan rules, for more information see
            https://doc.rust-lang.org/reference/items/implementations.html#trait-implementation-coherence
    = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#from_over_into
    = note: `#[warn(clippy::from_over_into)]` on by default
help: replace the `Into` implementation with `From<state_machine::RocketStates>`
    |
106 ~ impl From<RocketStates> for state::StateData {
107 ~     fn from(val: RocketStates) -> Self {
108 ~         match val {
    |

Check warning on line 71 in boards/recovery/src/communication.rs

See this annotation in the file changed.

@github-actions github-actions / clippy

this function has too many arguments (8/7)

warning: this function has too many arguments (8/7)
  --> boards/recovery/src/communication.rs:62:5
   |
62 | /     pub fn new<S>(
63 | |         can_rx: Pin<PA23, AlternateI>,
64 | |         can_tx: Pin<PA22, AlternateI>,
65 | |         pclk_can: Pclk<Can0, Gclk0Id>,
...  |
70 | |         loopback: bool,
71 | |     ) -> (Self, S::Inc)
   | |_______________________^
   |
   = help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#too_many_arguments
   = note: `#[warn(clippy::too_many_arguments)]` on by default