Update message size test #104
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NoahSprenger
requested changes
May 1, 2024
NoahSprenger
requested changes
May 1, 2024
libraries/messages/src/lib.rs
Outdated
| pub const MAX_HEALTH_SIZE: usize = 47; | ||
| pub const MAX_SENSOR_SIZE: usize = 53; | ||
| pub const MAX_STATE_SIZE: usize = 13; | ||
| pub const MAX_LOGNCOMMAND_SIZE: usize = 15; |
There was a problem hiding this comment.
I know they are the same size, but they might not always be the same size, can you split these.
NoahSprenger
reviewed
May 1, 2024
NoahSprenger
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the Mavlink dialect to have different messages based on the data type therefore updating the message size test to be based on the data type.