Health manager update #88
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, you still just need to remove the .vs folder. |
…recovery health.rs
|
I've pushed a new commit. Please checkout my changes 😄 Further, can you look into wrapping the ADC in options so that they can live as shared objects within RTIC. We want to share the ADCs so that they can be used for other tasks that are not just health related. You could create an ADC manager which is passed to the Health manager when we need to read from the adc pins. Or you can do options. Actually you should do options even if doing the ADC manager. If that didn't make sense then please reach out and I'll gladly explain further what I mean. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.