Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Crea un nuevo paquete para tener logica compartida entre los componentes.
Por ahora solo tiene las shared definitions pero con esto se podria hacer un refactor grande para solucionar #203
En un principio queria que los imports a este paquete queden como
import { ... } from '@shared/<el archivo>
. Esto se lograba usando typescript paths, que funcionaba bastante bien hasta que queria correr los tests e2e, ahi rompia (los tests unitarios y la extension funcionaban 😭).En fin, la conclusion a la que llegue es que:
Ademas de eso tambien meti estos cambios: