-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MOBILE-4771: Research Flutter SPM support #245
Conversation
.library( name: "airship-flutter", targets: ["airship_flutter"]) | ||
], | ||
dependencies: [ | ||
.package(url: "https://github.com/urbanairship/airship-mobile-framework-proxy.git", from: "11.2.2") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
need to set the correct new version of the proxy once urbanairship/airship-mobile-framework-proxy#75 is merged and released
Looks good - we might want to get the proxy released and maybe generate/set up an spm_example variant? I just attempted this with the local version of the proxy but I'm not able to get it running. Will try to get it building from the local proxy maybe tomorrow. |
@@ -2,7 +2,12 @@ | |||
|
|||
import UIKit | |||
import Flutter |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
does anything in this example actually need to change?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i've updated the example app to support both cocoapods and spm framework usage. adding flutter is required as if there is no cocoapods, the flutter dependency is not added
i was able to build it locally with the next settings:
let me know if the steps didn't work for you |
What do these changes do?
Why are these changes necessary?
https://urbanairship.atlassian.net/browse/MOBILE-4771
How did you verify these changes?
run flutter with SPM disabled (i.e. the old cocoapods way), make sure the app runs and archives with no problem
run flutter with SPM, make sure the app runs and archives with no problem
Anything else a reviewer should know?
the proxy pr must be merged before urbanairship/airship-mobile-framework-proxy#75 as these changes require more classes exposed from the proxy via SPM