USAGOV-2177: USAGOV-2177 breadcrumbs for directory pages #2173
+169
−61
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omerida
requested changes
Jan 15, 2025
|
Looks like the changes should be fine, will test locally but phpcs is flagging issues: https://app.circleci.com/pipelines/github/usagov/usagov-2021/12563/workflows/9f74e44b-f113-4b84-bd80-71c6101f099d/jobs/31552/parallel-runs/0/steps/0-104 @DaleMHFrey |
omerida
requested changes
Jan 22, 2025
web/modules/custom/usa_twig_vars/src/TaxonomyDatalayerBuilder.php
Outdated
Show resolved
Hide resolved
web/modules/custom/usa_twig_vars/src/TaxonomyDatalayerBuilder.php
Outdated
Show resolved
Hide resolved
omerida
reviewed
Jan 22, 2025
omerida
reviewed
Jan 22, 2025
omerida
reviewed
Jan 22, 2025
omerida
reviewed
Jan 22, 2025
omerida
requested changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://cm-jira.usa.gov/browse/USAGOV-2177
Description
For State & Agency pages, relocated breadcrumb logic to the template file, and made it look up the title of the node's parents.
Type of Changes
Testing Instructions
Go to a state page like
/states/alaskaor an agency page like/agencies/u-s-abilityone-commission- compare what you see on dev vs Prod. As said in the ticket:Good: The U.S. and its government
Bad: About the U.S. and its government
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Testand add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.