USAGOV-2163 - docker-bench-security

[DaleMHFrey]

https://cm-jira.usa.gov/browse/USAGOV-2163

Description

Made the container-build script run the Docker containers after building them. This allows the docker-bench-security run as expected. Additional logic was added in toe shut down the containers after the docker-bench-security scan is done.

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
• Other

Testing Instructions

Merge into Dev, approve the build-and-push-container process in CircleCI. When that build-and-push-container task is completed, the Check CMS CIS Benchmarks sub-task inside build-and-push-container - it should no longer say "No containers running" and have a much longer list of things it has checked (in comparison to this older one here)

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

[akf]

This is great. I think I've identified a bug, though. It looks like you're starting up a container from the cms image three times and not starting containers for the www or waf images.