-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usagov 2132 hide contact info by page #2186
base: dev
Are you sure you want to change the base?
Conversation
…gion and block positions
…nt Administrator role
…called by twig file. Forbidden pages added to mobile
…origin' into USAGOV-2132-hide-contact-info-by-page
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I took a look at this and unfortunately the blocks are broken for me. I now remember running into this before -- the blocks you exported as config are somewhat present, but are "broken."
I can get to the edit pages for them by clicking "configure" next to the message "This block is broken or missing" when viewing a node. So I can find my way to, for example, http://localhost/admin/structure/block/manage/usagov_topnavphone and I can see the Visibility configuration, but the Block description says "Broken/Missing."
The new blocks do not appear at /admin/content/block
Is this what you meant by "Content may be required for this to work." ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's not give this permission to Content Administrators. We've given too many people that role.
An alternative would be to add a new role (maybe "Content Superadmin") with the administer blocks
permission and give it to selected people in addition to the "Content Administrator" role.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akf Updated task to include structure sync which treats block content like config.
…origin' into USAGOV-2132-hide-contact-info-by-page
…ture sync module, top phone nav
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2132
Description
Goal of this task is to hide call center info on certain pages.
Call center info can appear in the header, footer, and mobile menu.
I created a new role of content_superadmin whose only perm is administer blocks
Created new regions for this task
For this to work, config, code and content have to be in sync. To achieve this, I added a new module "Structure Sync". It allows for devs to export blocks, menus, and taxonomy content as config. Blocks are the only ones currently in use.
Type of Changes
Testing Instructions
You must run bin/composer install to gain access to the structure sync module.
Then, go to http://localhost/admin/structure/structure-sync/blocks.
Next, click on the Import custom blocks (safely) button
Contact info should not be visible the following pages:
New blocks can found under content blocks
Position of new block can be found at Block Layout
Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.