Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

USAGOV-2180: USAGOV-2180 - Adding in aggregation reporter #2188

Open
wants to merge 5 commits into
base: dev
Choose a base branch
from

Conversation

DaleMHFrey
Copy link
Contributor

https://cm-jira.usa.gov/browse/USAGOV-2180

Description

Added in a report to report duplicate URL-query string as part of (see Jira ticket USAGOV-2180)

Type of Changes

  • New Feature
  • Bugfix
  • Frontend (Twig, Sass, JS)
  • Drupal Config (requires "drush cim")
  • New Modules (requires rebuild)
  • Documentation
  • Infrastructure
  • Other

Testing Instructions

When merged, you can run this script with php -f scripts/report-aggregated-css-js.php. This will write a report to report.csv and then output noticed duplicate-issues into the terminal.

Reviewer Reminders

  • Reviewed code changes
  • Reviewed functionality
  • Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

  1. Go to the USAGov Circle CI project.
  2. Find the commit of this pull request.
  3. Build and deploy the changes.
  4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.

@whitealbum
Copy link
Contributor

@DaleMHFrey Should report.csv be added to .gitignore? Currently, when a report is generated, it is eligible to be added to the repo.

@DaleMHFrey
Copy link
Contributor Author

@DaleMHFrey Should report.csv be added to .gitignore? Currently, when a report is generated, it is eligible to be added to the repo.

Ah, good catch - this is now resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants