-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Usagov 2206 hide call center js #2193
Open
whitealbum
wants to merge
14
commits into
dev
Choose a base branch
from
USAGOV-2206-hide-call-center-js
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…css if value is -1
…' into USAGOV-2206-hide-call-center-js
…' into USAGOV-2206-hide-call-center-js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2206
Description
script runs on all pages, if api returns -1, css is injected to hide contact info.
Type of Changes
Testing Instructions
You can add
actualSeconds = -1;
to the top ofcreateDisplayWaitTime()
. This should force the logic into the 'else' statement where it will call theinjectCSS()
function. Any element with thedata-contact-callout
attribute should no longer be visible.data-contact-callout="visible"
should change todata-contact-callout="hidden"
andstyle="display: none;"
should be appended to the end.<span id="top-phone" class="usa-nav__secondary-item" data-contact-callout="hidden" style="display: none;">
If
actualSeconds != -1
, the contact center stuff should show 80% of the time. To test this, simply reload the page several times. If at any point the contact info isn't visible, this works.Change Requirements
Validation Steps
Security Review
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Review in Test
and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.