USAGOV 2190 phpstan directories

[omerida]

Jira Task

https://cm-jira.usa.gov/browse/USAGOV-2190

Description

Adds type hints to function arguments and return types.
Refactor the views pre-render hook to use NodeInterface methods.

Type of Changes

• New Feature
• Bugfix
• Frontend (Twig, Sass, JS)
  • Add screenshot showing what it should look like
• Drupal Config (requires "drush cim")
• New Modules (requires rebuild)
• Documentation
• Infrastructure
  • CMS
  • WAF
  • WWW
  • Egress
  • Tools
  • Cron
• Other

Testing Instructions

Change Requirements

• Requires New Documentation (Link: {})
• Requires New Config
• Requires New Content

Validation Steps

• Compare agency index English and Spanish pages - the letters for navigation should be the same as on prod
• Compare tome export of dev versus this branch. There should be no changes. You may need to tweak the diff command to exclude the sites/default/files folder holding aggregated JS/CSS files. See https://github.com/usagov/usagov-2021/wiki/tome#testing-changes
• Compare published pages CSV exported by dev versus this branch. There should be no differences.

Security Review

• Adds/updates software (including a library or Drupal module)
• Communication with external service
• Changes permissions or workflow
• Requires SSPP updates

Reviewer Reminders

• Reviewed code changes
• Reviewed functionality
• Security review complete or not required

Post PR Approval Instructions

Follow these steps as soon as you merge the new changes.

1. Go to the USAGov Circle CI project.
2. Find the commit of this pull request.
3. Build and deploy the changes.
4. Update the Jira ticket by changing the ticket status to Review in Test and add a comment. State whether the change is already visible on cms-dev.usa.gov and beta-dev.usa.gov, or if the deployment is still in process.