USAGOV-2207: update cg logshipper version, add testing notes #20
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pper and modify deployment scripts to provide an easier path to deploying test instances
…esting use and update README
…ting setup/teardown instructions
…h 'origin/main' into USAGOV-2207-update-cg-logshipper-version
…eplace temp hostname string with usagov-tools
arpage
reviewed
Jan 27, 2025
| @@ -15,7 +15,7 @@ commands: | |||
| name: CloudGov Deploy | |||
| command: | | |||
| cf target -s $LOG_SHIPPER_SPACE | |||
| ./bin/deploy-logshipper.sh << pipeline.number >> | |||
| ./bin/deploy-logshipper.sh 3 << pipeline.number >> | |||
There was a problem hiding this comment.
@akf - I would leave a comment above deploy-logshipper.sh 3 explaining the 3. It looks like either a magic number (or some sort of redirect, with the circleci delimiters <<) until one reads the deploy-loggshipper.sh source code.
arpage
reviewed
Jan 27, 2025
bin/add-log-drains-for-space.sh
Outdated
| exit 1 | ||
| fi | ||
|
|
||
| SERVICE_EXISTS=`cf service ${DRAIN_NAME} --guid` |
There was a problem hiding this comment.
This is just a style comment - the backticks `` for spawning a subshell is superseded by $( command )
arpage
reviewed
Jan 27, 2025
There was a problem hiding this comment.
Hi Amy - this looks good, and it worked for me (with the exception of NR traffic, which I expected not to work).
I am attaching a sample of the error messages I received, in case they are not NR related.
2025-01-27T10:57:46.78-0500 [APP/PROC/WEB/SIDECAR/FLUENTBIT/0] ERR time="2025-01-27T15:57:46Z" level=info msg="Retryable error received. Will retry to send the logs (if there are attempts remaining, check Retry_Limit option)" error="Post \"https://gov-log-api.newrelic.com/log/v1\": dial tcp 162.247.241.138:443: connect: connection refused"
2025-01-27T10:57:46.78-0500 [APP/PROC/WEB/SIDECAR/FLUENTBIT/0] ERR [2025/01/27 15:57:46] [error] [engine] chunk '13-1737993455.128500460.flb' cannot be retried: task_id=3, input=tcp.1 > output=newrelic.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jira Task
https://cm-jira.usa.gov/browse/USAGOV-2077
Description
Updated the
checkoutcommand for cg-logshipper to use thev1.0tag.Needed to test it, so I teased out some of the hard-coded values in the deployment scripts so I could use them to deploy to a test space, and added instructions for testing to the README.
Type of Changes
Testing Instructions
Please review the new testing hints in the README. Try them out if you feel so inclined!
Security Review
Updates cg-logshipper, which in turn updates fluent-bit to version 3.2.4. I don't know of any security-related changes in those updates, though.
Reviewer Reminders
Post PR Approval Instructions
Follow these steps as soon as you merge the new changes.
Doneand add a comment.