Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-3286 Update NVRF to v1.0.0 #1190

Merged
merged 5 commits into from
Jan 31, 2025
Merged

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jan 13, 2025

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3286

Description

Update the NVRF app to https://github.com/usagov/vote-gov-nvrf-app/releases/tag/v0.22.1

Deployment and testing

Post-deploy steps

  1. lando retune

Update NVRF footer content

  1. Visit http://vote-gov.lndo.site/admin/content/block/21 and add a new line at the top of the wysiwyg @state_name information last updated @date
  2. Visit http://vote-gov.lndo.site/es/admin/content/block/21 and add a new line at the top of the wysiwyg @state_name información actualizada por última vez @date

Update NVRF select fields

  1. add - Select - with value default for these fields
  1. add - Elija - with value default from these fields

QA/Testing instructions

  1. Fill out the form using the "confirm registration" path. Test/enable every field as you go through the steps.
  2. Confirm all values show up correctly on the confirm registration page.
  3. Confirm all values map correctly to the generated PDF
  4. Repeat for Spanish

See individual PRs in the release version if you want to test specific features.

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

@rayestrada rayestrada changed the title VOTE-3286 Update NVRF to v0.22.1 VOTE-3286 Update NVRF to v1.0.0 Jan 30, 2025
@rayestrada rayestrada merged commit c571aff into dev Jan 31, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants