Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VOTE-3303 Fix NVRF missing font console error #1192

Open
wants to merge 4 commits into
base: dev
Choose a base branch
from

Conversation

SamiraMSadat
Copy link
Contributor

@SamiraMSadat SamiraMSadat commented Jan 15, 2025

Jira ticket

https://cm-jira.usa.gov/browse/VOTE-3112

Description

Add a command to package.json to move all font files to the dist/assets folder

Deployment and testing

Post-deploy steps

  1. Delete all files in ./dist/assets folder
  2. cd into vote_nvrf module fold, run npm run build

QA/Testing instructions

  1. Visit http://vote-gov.lndo.site/register/colorado/mail-in-form-filler in mulitple browsers and confirm the console is free of errors

Checklist for the Developer

  • A link to the JIRA ticket has been included above.
  • No merge conflicts exist with the target branch.
  • Automated tests have passed on this PR.
  • A reviewer has been designated.
  • Deployment and testing steps have been documented above, if applicable.

Checklist for the Peer Reviewers

  • The file changes are relevant to the task objective.
  • Code is readable and includes appropriate commenting.
  • Code standards and best practices are followed.
  • QA/Test steps were successfully completed, if applicable.
  • Applicable logs are free of errors.

Copy link
Contributor

@rayestrada rayestrada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets meet to talk about this one. I was expecting a css file that was very small and no font files processing.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the font files?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we remove the font files?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants