feat utils: disallow falling back to Boost.Regex by default

commit_hash:41d5cfa759e263c424316c91e74369cb9e25981a
userver-framework · Jan 23, 2025 · 34dfaa8 · 34dfaa8
1 parent 3b561d9
commit 34dfaa8
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/core/src/components/manager_config.hpp b/core/src/components/manager_config.hpp
@@ -29,7 +29,7 @@ struct ManagerConfig {
     bool mlock_debug_info{true};
     bool disable_phdr_cache{false};
     bool preheat_stacktrace_collector{true};
-    bool implicit_boost_regex_fallback_allowed{true};
+    bool implicit_boost_regex_fallback_allowed{false};
 
     static ManagerConfig FromString(
         const std::string&,

diff --git a/universal/src/utils/regex.cpp b/universal/src/utils/regex.cpp
@@ -38,7 +38,7 @@ class RegexErrorImpl : public RegexError {
 namespace {
 
 constexpr std::size_t kGroupsSboSize = 5;
-USERVER_IMPL_CONSTINIT std::atomic<bool> implicit_boost_regex_fallback_allowed{true};
+USERVER_IMPL_CONSTINIT std::atomic<bool> implicit_boost_regex_fallback_allowed{false};
 
 re2::RE2::Options MakeRE2Options() {
     re2::RE2::Options options{};
@@ -402,9 +402,7 @@ std::string regex_replace(std::string_view str, const regex& pattern, std::strin
 
 bool IsImplicitBoostRegexFallbackAllowed() noexcept { return true; }
 
-void SetImplicitBoostRegexFallbackAllowed(bool allowed) noexcept {
-    UINVARIANT(allowed, "Cannot stop using boost::regex, because re2 is disabled");
-}
+void SetImplicitBoostRegexFallbackAllowed(bool /*allowed*/) noexcept {}
 
 #endif