-
Notifications
You must be signed in to change notification settings - Fork 174
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
USWDS-Site: Remove video tutorials and add monthly calls #2345
Conversation
No longer using the playlist - instead, showing a list of individual MCs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have added two suggestions.
Co-authored-by: Sarah Schroeder <[email protected]>
Co-authored-by: Sarah Schroeder <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, page looks good
@sarah-sch I committed your suggestions. Will you take a look at the page preview and let me know if you want any changes? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Some super minor suggestions but overall I love this!
Testing checklist
- Confirm that the video tutorials page has been removed and the url redirects to the monthly calls page
- Confirm that the video tutorials page is removed from the side navigation
- Confirm that the new monthly calls page exists and has appropriate, accurate content
- Confirm that the new monthly calls page is added to the side navigation
- Confirm that the on-page navigation works and reads as expected
- Changelog is added
@amyleadem - sorry that I missed your request to review yesterday, but looks great! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These changes look good to me.
I don't think the playlist-only solution is best solution here. We have all these monthly calls, and all these different topics, but this makes it feel like there's only one. We have a real opportunity here to help direct folks to a specific monthly call, and to get a sense of the breadth of their topics. The overhead of adding new videos from month to month is worth it if we can point folks to this page and make it useful for finding a specific monthly call on a topic that's useful to the vistor |
@thisisdano No problem! We are working on including some more of the details that were in your spreadsheet now. I'll ping both you and @sarah-sch when it is ready. Edit: That is, unless you are happy with it is in its current state! |
Oh cool. I added an example of how it might work with a couple of commits, but feel free to modify or just use your own solution |
@thisisdano Here is what ours was looking like (Not too different!). Let me know if you have a preference and I can update the data. |
@thisisdano @sarah-sch I went ahead and included both the bulleted event details and the subtitle. I am going to come back through tomorrow morning to validate all of the data. Let me know if you want any changes to the template! |
Clearing this review because we re-worked the page content and it needs new approval.
Update: I ended up validating the data today instead. Let me know if you have questions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, @amyleadem, I'm requesting a few changes.
@sarah-sch and @thisisdano I have updated the layout to include the monthly calls from January-October 2023 and validated the data. Will you take a look and let me know what you think? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@amyleadem - sorry to keep adding changes - I am suggesting descriptions for the couple of months that don't have them. This change will make the different month entries more uniform.
I've made the requested changes. Please let me know if you need anything else! |
Looks great to me, thank you! |
Summary
Related issue
Closes #2333
Preview link
Problem statement
The video tutorials page is outdated and has broken content. We should remove this page and redirect the video tutorials page to a new monthly calls page.
Solution
Testing and review